Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spinner #1332

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Spinner #1332

merged 3 commits into from
Nov 18, 2024

Conversation

hextion
Copy link
Collaborator

@hextion hextion commented Aug 12, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 12, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 2dfe3b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 77 packages
Name Type
@alfalab/core-components-spinner Major
@alfalab/core-components-shared Minor
@alfalab/core-components-action-button Patch
@alfalab/core-components-button Patch
@alfalab/core-components-confirmation Patch
@alfalab/core-components-file-upload-item-v1 Patch
@alfalab/core-components-file-upload-item Patch
@alfalab/core-components-amount-input Patch
@alfalab/core-components-base-modal Patch
@alfalab/core-components-bottom-sheet Patch
@alfalab/core-components-calendar-input Patch
@alfalab/core-components-calendar Patch
@alfalab/core-components-checkbox-group Patch
@alfalab/core-components-checkbox Patch
@alfalab/core-components-code-input Patch
@alfalab/core-components-custom-picker-button Patch
@alfalab/core-components-date-range-input Patch
@alfalab/core-components-date-time-input Patch
@alfalab/core-components-filter-tag Patch
@alfalab/core-components-form-control Patch
@alfalab/core-components-input-autocomplete Patch
@alfalab/core-components-input Patch
@alfalab/core-components-international-phone-input Patch
@alfalab/core-components-markdown Patch
@alfalab/core-components-modal Patch
@alfalab/core-components-navigation-bar-private Patch
@alfalab/core-components-navigation-bar Patch
@alfalab/core-components-number-input Patch
@alfalab/core-components-pass-code-v1 Patch
@alfalab/core-components-pass-code Patch
@alfalab/core-components-pattern-lock-v1 Patch
@alfalab/core-components-pattern-lock Patch
@alfalab/core-components-picker-button Patch
@alfalab/core-components-popup-sheet Patch
@alfalab/core-components-portal Patch
@alfalab/core-components-product-cover Patch
@alfalab/core-components-pure-cell Patch
@alfalab/core-components-radio-group Patch
@alfalab/core-components-radio Patch
@alfalab/core-components-select-with-tags Patch
@alfalab/core-components-select Patch
@alfalab/core-components-side-panel Patch
@alfalab/core-components-sortable-list Patch
@alfalab/core-components-switch Patch
@alfalab/core-components-system-message Patch
@alfalab/core-components-tab-bar Patch
@alfalab/core-components-tabs Patch
@alfalab/core-components-tag Patch
@alfalab/core-components-textarea Patch
@alfalab/core-components-toast-plate Patch
@alfalab/core-components-toast Patch
@alfalab/core-components-tooltip Patch
@alfalab/core-components-universal-date-input Patch
@alfalab/core-components-attach Patch
@alfalab/core-components-confirmation-v1 Patch
@alfalab/core-components-custom-button Patch
@alfalab/core-components-icon-button Patch
@alfalab/core-components-plate Patch
@alfalab/core-components-table Patch
@alfalab/core-components-drawer Patch
@alfalab/core-components-gallery Patch
@alfalab/core-components-calendar-range Patch
@alfalab/core-components-calendar-with-skeleton Patch
@alfalab/core-components-intl-phone-input Patch
@alfalab/core-components-date-input Patch
@alfalab/core-components-masked-input Patch
@alfalab/core-components-password-input Patch
@alfalab/core-components-slider-input Patch
@alfalab/core-components-time-input Patch
@alfalab/core-components-with-suffix Patch
@alfalab/core-components-notification-manager Patch
@alfalab/core-components-notification Patch
@alfalab/core-components-popover Patch
@alfalab/core-components-pagination Patch
@alfalab/core-components-alert Patch
@alfalab/core-components-bank-card Patch
@alfalab/core-components-phone-input Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Aug 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11888956170

Details

  • 32 of 36 (88.89%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 82.548%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/shared/src/object.ts 4 5 80.0%
packages/shared/src/warning.ts 1 4 25.0%
Totals Coverage Status
Change from base Build 11816249410: -0.04%
Covered Lines: 10385
Relevant Lines: 11505
💛 - Coveralls

@hextion hextion force-pushed the feat/you-spin-me-round branch 3 times, most recently from ec3d511 to 9a7851f Compare August 12, 2024 21:50
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@hextion hextion force-pushed the feat/you-spin-me-round branch from 9a7851f to f0cdaa0 Compare August 14, 2024 12:10
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@hextion hextion force-pushed the feat/you-spin-me-round branch from f0cdaa0 to 1190c72 Compare August 15, 2024 10:12
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@hextion hextion force-pushed the feat/you-spin-me-round branch from 1190c72 to 8ec4750 Compare August 29, 2024 17:51
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@hextion hextion force-pushed the feat/you-spin-me-round branch 3 times, most recently from 8f58545 to 00dbdc0 Compare August 29, 2024 20:34
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@hextion hextion force-pushed the feat/you-spin-me-round branch 3 times, most recently from db158d7 to 6e68368 Compare September 4, 2024 19:46
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@hextion hextion force-pushed the feat/you-spin-me-round branch from 6e68368 to b182f6a Compare September 5, 2024 09:52
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@hextion hextion force-pushed the feat/you-spin-me-round branch from 1a6e493 to 7398e1c Compare October 28, 2024 21:00
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@hextion hextion force-pushed the feat/you-spin-me-round branch from ebe25f5 to 8bc60ea Compare October 31, 2024 15:49
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@hextion hextion mentioned this pull request Nov 1, 2024
Closed
@hextion hextion force-pushed the feat/you-spin-me-round branch 2 times, most recently from 53b9af9 to 15168ae Compare November 5, 2024 12:44
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@hextion hextion force-pushed the feat/you-spin-me-round branch from 15168ae to bc71f76 Compare November 11, 2024 12:14
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

SiebenSieben
SiebenSieben reviewed Nov 15, 2024
View reviewed changes
packages/spinner/src/docs/Component.stories.mdx Outdated
})}
</Story>

<Story name='Преднастроенный вариант'>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

У нас в навигации в компонентах на английском (тот же Docs)

Напишем Preset?

SiebenSieben
SiebenSieben reviewed Nov 15, 2024
View reviewed changes
.changeset/cuddly-jeans-laugh.md Outdated
- `size` - теперь отвечает за размер кольца спиннера;
- `lineWidth` - толщина линии спиннера;
- `style` - позволяет регулировать отступы, цвет и т.п.
* Добавлен `codemod` для бесшовной миграции `Spinner`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В codemod надо дополнить README и отдельно запаблишить, а здесь можно добавить ссылку типа https://www.npmjs.com/package/@alfalab/core-components-codemod/v/2.6.1

SiebenSieben
SiebenSieben reviewed Nov 15, 2024
View reviewed changes
packages/spinner/src/docs/description.mdx Outdated
Label
</Button>
<br/>
<Button block={true} leftAddons={<Spinner visible={true} />} size='m'>
<Button block={true} leftAddons={<Spinner visible={true} />} size={56}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут не хватает preset? Спиннер не отображается

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да, здесь пресет. Поправлю

@SiebenSieben
Copy link
Contributor

В компонентах где используется Spinner везде перевели на пресеты? Судя по скриншотам, в FileUploadItem размер спиннера увеличился, вероятно надо поправить

@hextion hextion force-pushed the feat/you-spin-me-round branch from bc71f76 to 0d5cacb Compare November 18, 2024 08:55
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@hextion hextion force-pushed the feat/you-spin-me-round branch from 0d5cacb to 2aff3a7 Compare November 18, 2024 12:37
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@hextion hextion force-pushed the feat/you-spin-me-round branch from 2aff3a7 to 6d68199 Compare November 18, 2024 13:30
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@hextion hextion force-pushed the feat/you-spin-me-round branch from 6d68199 to ca9819e Compare November 18, 2024 15:14
@hextion hextion force-pushed the feat/you-spin-me-round branch from ca9819e to 2dfe3b0 Compare November 18, 2024 15:21
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@hextion hextion merged commit c757c49 into master Nov 18, 2024
7 checks passed
@hextion hextion deleted the feat/you-spin-me-round branch November 18, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiebenSieben SiebenSieben SiebenSieben left review comments

@reme3d2y reme3d2y reme3d2y left review comments

@fulcanellee fulcanellee fulcanellee approved these changes

@Oladii Oladii Oladii approved these changes

@churicheva-v churicheva-v churicheva-v approved these changes

Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@hextion @coveralls @core-ds-bot @SiebenSieben @reme3d2y @fulcanellee @Oladii @churicheva-v