Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add additional classname for appId in gallery #1436

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

ViralLka
Copy link
Contributor

@ViralLka ViralLka commented Nov 5, 2024

Опишите проблему

При подключении фичи для изоляции стилей, перестала работать галерея. Для этого нужно прокинуть новый класс, который будет содержать appId приложения, и стили после этого будут отрабатывать корректно.

Шаги для воспроизведения

  1. Перейти на страницу '...'
  2. Нажать на кнопку '...'

Ожидаемое поведение

При нажатии на кнопку должно появится модальное окно

Чек лист

  • Тесты
  • Документация

Внешний вид

Ожидаемый Фактический
** Ожидаемый ** ** Фактический **

Тестовый стенд

Десктоп (если данных нет оставте блок пустым):

  • OS: MacOS
  • Browser: Safari
  • Version: 10

Смартфон (если данных нет оставте блок пустым):

  • Device: iPhone 6
  • OS: iOS 10
  • Browser: Chrome
  • Version: 65

Дополнительная информация

Дополнительная информация

Copy link

changeset-bot bot commented Nov 5, 2024

🦋 Changeset detected

Latest commit: dffce99

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@alfalab/core-components-gallery Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Nov 5, 2024

Pull Request Test Coverage Report for Build 11683759555

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 82.607%

Totals Coverage Status
Change from base Build 11683320714: 0.001%
Covered Lines: 10364
Relevant Lines: 11476

💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@fulcanellee fulcanellee merged commit aaad91f into master Nov 5, 2024
7 checks passed
@fulcanellee fulcanellee deleted the feature/add-popup-classname branch November 5, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants