feat(custom-button): split custom button by desktop / mobile #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulcanellee
requested review from
reme3d2y,
SiebenSieben and
hextion
as code owners
🦋 Changeset detectedLatest commit: c4d1721 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Bundle size report
|
Pull Request Test Coverage Report for Build 12462101745Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
Собрана новая демка. |
|
добавь плез |
fulcanellee
changed the title
hextion
requested changes
Dec 3, 2024
denisx
reviewed
Dec 3, 2024
|
Собрана новая демка. |
…ustom-button_split
|
Переделал реализацию. Теперь разделение проходит через базовый (base) компонент. Просьба проверить заново. |
fulcanellee
force-pushed
the
feat/custom-button_split
branch
from
ce7b9cf to
0890ee2
Compare
|
Собрана новая демка. |
denisx
reviewed
Dec 11, 2024
packages/custom-button/src/components/base-custom-button/base-custom-button.tsx
Show resolved
Hide resolved
packages/custom-button/src/components/base-custom-button/base-custom-button.tsx
Show resolved
Hide resolved
packages/custom-button/src/components/base-custom-button/base-custom-button.tsx
Show resolved
Hide resolved
packages/custom-button/src/components/base-custom-button/base-custom-button.tsx
Show resolved
Hide resolved
packages/custom-button/src/components/base-custom-button/base-custom-button.tsx
Outdated
Show resolved
Hide resolved
|
Собрана новая демка. |
denisx
reviewed
Dec 21, 2024
|
Собрана новая демка. |
denisx
approved these changes
Dec 23, 2024
hextion
approved these changes
Dec 23, 2024
SiebenSieben
approved these changes
Dec 26, 2024
reme3d2y
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавляет возможность использовать custom button для desktop / mobile по отдельности