Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: components mirgration to Typography atoms #1473

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Conversation

denisx
Copy link
Contributor

@denisx denisx commented Nov 29, 2024

Опишите проблему

  • Переход на атомарные импорты Typography.[Name] -> [Name] внутри кор-компонентов, подсушить пакеты

Внешний вид

Без изменений https://core-ds.github.io/core-components/feat_DS_7758_8_7d83f0f45b2088375dd0077408c964f0faf34aad/

Дополнительная информация

Стори и кодмоды не трогал, это отдельно

Copy link

changeset-bot bot commented Nov 29, 2024

🦋 Changeset detected

Latest commit: 3edae9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@alfalab/core-components-accordion Patch
@alfalab/core-components-calendar Patch
@alfalab/core-components-chart Patch
@alfalab/core-components-circular-progress-bar Patch
@alfalab/core-components-comment Patch
@alfalab/core-components-confirmation Patch
@alfalab/core-components-file-upload-item Patch
@alfalab/core-components-gallery Patch
@alfalab/core-components-list Patch
@alfalab/core-components-list-header Patch
@alfalab/core-components-markdown Patch
@alfalab/core-components-navigation-bar Patch
@alfalab/core-components-navigation-bar-private Patch
@alfalab/core-components-product-cover Patch
@alfalab/core-components-pure-cell Patch
@alfalab/core-components-stepped-progress-bar Patch
@alfalab/core-components-tab-bar Patch
@alfalab/core-components-calendar-input Patch
@alfalab/core-components-calendar-range Patch
@alfalab/core-components-calendar-with-skeleton Patch
@alfalab/core-components-date-range-input Patch
@alfalab/core-components-date-time-input Patch
@alfalab/core-components-bottom-sheet Patch
@alfalab/core-components-modal Patch
@alfalab/core-components-popup-sheet Patch
@alfalab/core-components-side-panel Patch
@alfalab/core-components-select-with-tags Patch
@alfalab/core-components-select Patch
@alfalab/core-components-tooltip Patch
@alfalab/core-components-custom-picker-button Patch
@alfalab/core-components-input-autocomplete Patch
@alfalab/core-components-international-phone-input Patch
@alfalab/core-components-intl-phone-input Patch
@alfalab/core-components-picker-button Patch
@alfalab/core-components-table Patch
@alfalab/core-components-tabs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@core-ds-bot
Copy link
Collaborator

core-ds-bot commented Nov 29, 2024

Bundle size report

Entry point Size (minified)
tab-bar/index.js 8.6 (-3.90 KB)
stepped-progress-bar/index.js 5.8 (-3.90 KB)
product-cover/index.js 37.2 (-3.70 KB)
navigation-bar/shared.js 12.4 (-3.70 KB)
markdown/desktop.js 125.2 (-2.60 KB)
markdown/mobile.js 125.2 (-2.60 KB)
list/index.js 6.4 (-3.90 KB)
list-header/index.js 5.2 (-3.90 KB)
comment/index.js 5.1 (-4.00 KB)
circular-progress-bar/index.js 8.8 (-3.10 KB)
chart/index.js 439.2 (-3.70 KB)
accordion/index.js 16.6 (-3.70 KB)

@coveralls
Copy link

coveralls commented Nov 29, 2024

Pull Request Test Coverage Report for Build 12089114804

Details

  • 29 of 29 (100.0%) changed or added relevant lines in 28 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.403%

Totals Coverage Status
Change from base Build 12069391778: 0.0%
Covered Lines: 10620
Relevant Lines: 11766

💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@denisx denisx changed the title feat: some components change to atoms import feat: components mirgration to Typography atoms Nov 30, 2024
@denisx denisx marked this pull request as ready for review November 30, 2024 07:07
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@hextion hextion merged commit bcd44b3 into master Dec 12, 2024
7 checks passed
@hextion hextion deleted the feat/DS-7758_8 branch December 12, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants