-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: product-cover: исправлено название пропса numberOfCards #1489
Open
denisx
wants to merge
10
commits into
master
Choose a base branch
from
fix/product-cover_11-12-2024
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: db95825 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Собрана новая демка. |
denisx
changed the title
Fix/product cover 11 12 2024
product-cover: Исправлено название пропса numberOfCards
Dec 11, 2024
denisx
changed the title
product-cover: Исправлено название пропса numberOfCards
ProductCover: Исправлено название пропса numberOfCards
Dec 11, 2024
Pull Request Test Coverage Report for Build 12710318240Details
💛 - Coveralls |
Собрана новая демка. |
denisx
requested review from
reme3d2y,
fulcanellee,
SiebenSieben and
hextion
as code owners
December 11, 2024 17:01
denisx
changed the title
ProductCover: Исправлено название пропса numberOfCards
fix: product-cover: исправлено название пропса numberOfCards
Dec 11, 2024
Собрана новая демка. |
SiebenSieben
approved these changes
Dec 25, 2024
hextion
requested changes
Jan 9, 2025
fulcanellee
approved these changes
Jan 9, 2025
Собрана новая демка. |
hextion
approved these changes
Jan 10, 2025
Собрана новая демка. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Опишите проблему
Исправлено название пропса numberOfCards. Старый пропс (numberOfСards с русской C) оставлен для обратной совместимости, но помечен как деприкейт. При использовании сразу обоих, новый имеет приоритет.
Если есть визуальные изменения
Без изменений https://core-ds.github.io/core-components/fix_product_cover_11_12_2024_7c6f4c4e928a5fa99d748231cfd8ec220f6e7974/?path=/docs/productcover--docs