Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: product-cover: исправлено название пропса numberOfCards #1489

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

denisx
Copy link
Contributor

@denisx denisx commented Dec 10, 2024

Опишите проблему

Исправлено название пропса numberOfCards. Старый пропс (numberOfСards с русской C) оставлен для обратной совместимости, но помечен как деприкейт. При использовании сразу обоих, новый имеет приоритет.

Если есть визуальные изменения

Без изменений https://core-ds.github.io/core-components/fix_product_cover_11_12_2024_7c6f4c4e928a5fa99d748231cfd8ec220f6e7974/?path=/docs/productcover--docs

Copy link

changeset-bot bot commented Dec 10, 2024

🦋 Changeset detected

Latest commit: db95825

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@alfalab/core-components-product-cover Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@denisx denisx changed the title Fix/product cover 11 12 2024 product-cover: Исправлено название пропса numberOfCards Dec 11, 2024
@denisx denisx changed the title product-cover: Исправлено название пропса numberOfCards ProductCover: Исправлено название пропса numberOfCards Dec 11, 2024
@coveralls
Copy link

coveralls commented Dec 11, 2024

Pull Request Test Coverage Report for Build 12710318240

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 82.32%

Totals Coverage Status
Change from base Build 12708382287: 0.005%
Covered Lines: 10749
Relevant Lines: 11915

💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@denisx denisx marked this pull request as ready for review December 11, 2024 17:01
@denisx denisx changed the title ProductCover: Исправлено название пропса numberOfCards fix: product-cover: исправлено название пропса numberOfCards Dec 11, 2024
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

.changeset/big-apples-vanish.md Outdated Show resolved Hide resolved
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants