feat(gallery): changed colors and sizes in placeholders and nav #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temss-front
requested review from
reme3d2y,
fulcanellee,
SiebenSieben and
hextion
as code owners
🦋 Changeset detectedLatest commit: 2bd01f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Собрана новая демка. |
|
Собрана новая демка. |
|
@Oladii нужно ревью от тебя |
SiebenSieben
approved these changes
Jan 24, 2025
fulcanellee
reviewed
Jan 24, 2025
| @@ -176,8 +169,6 @@ export const ImageViewer: FC = () => { | |||
| index={index} | |||
| imageAspectRatio={imageAspectRatio} | |||
| slideVisible={slideVisible} | |||
| handleLoad={handleLoad} | |||
There was a problem hiding this comment.
это так и должно быть? не совсем понял
There was a problem hiding this comment.
это так и должно быть? не совсем понял
там хук написали, я в компоненте просто это из хука получаю. не вижу смысла прокидывать пропс
There was a problem hiding this comment.
Oladii
approved these changes
Jan 24, 2025
SiebenSieben
approved these changes
Jan 24, 2025
fulcanellee
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.