fix(intl-phone-input): ability to overwrite country-data #1562
+58
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikhail-yurin
requested review from
reme3d2y,
fulcanellee,
SiebenSieben and
hextion
as code owners
🦋 Changeset detectedLatest commit: 09a5a9f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pull Request Test Coverage Report for Build 13114230259Details
💛 - Coveralls |
fulcanellee
approved these changes
Feb 3, 2025
| /** | ||
| * | ||
| * Список правил парсинга номеров телефонов по странам (для переопределения дефолтного) | ||
| * @type {CountriesData[]} |
There was a problem hiding this comment.
Пожалуй это лишнее (@type {CountriesData[]}), ведь мы находимся в парадигме ts и переданный тип для пропса говорит сам за себя.
There was a problem hiding this comment.
Это описание (вместе с типом) нужно для сторибука, благодаря этому doc отображается параметр с его описанием
There was a problem hiding this comment.
я имел ввиду только строчку 50, где указан @type. описание трогать не нужно
|
|
Собрана новая демка. |
|
|
Собрана новая демка. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Опишите проблему
Требование от НСПК: возможная длина номера тлф до 15 цифр
Добавил пропс для переопределения дефолтного массива countriesData, чтобы по месту использования компонента можно было передать массив в котором уже будет нужная длина номеров телефонов