add support for /tmp/pycore.nnnnn/environment file, DRY up env merges #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siliconja
commented
Oct 2, 2020
daemon/core/emulator/session.py
Outdated
| @@ -978,6 +978,15 @@ def runtime_state_hook(self, _state: EventTypes) -> None: | |||
| corexmldeployment.CoreXmlDeployment(self, xml_writer.scenario) | |||
| xml_writer.write(xml_file_name) | |||
|
|
|||
There was a problem hiding this comment.
the helper below is just to DRY up the code...
…coregui user environment as a possibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already support
/etc/core/environment(system-wide) and/home/user/.core/environment(user-specific) environments. This adds a 3rd optional environment file:/tmp/pycore.nnnnn/environment.The use case here is an automated build and testing system that spawns a new session. The code being tested under that system has been build under e.g.
myapp/build/usr/local/bin/myappd, so the Python script that is building the session will automatically adjust the LD_SEARCH_PATH and PATH environment variables to reference e.g.myapp/build/usr/local/binandmyapp/build/usr/local/lib.In this manner, multiple of these test sessions may be running on the system simultaneously testing different builds of the software.