Changed CoreNode inheritance and CoreInterface class call on physical interfaces #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for bringing this up, I will take a look at this. Appreciate it. |
|
Pushed fixes for this on develop, if you want to try. Needed to fix another related issue as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you do a topology with RJ45 interface this get an error because class calls changed in latest versions and this has not been updated.
Topology:
Error:
It's on Core release 8.0.0, with python 3.8 and FRR, if you need to know. I used this vagrant file: https://github.com/cristianbarbaro/vagrant-coreemu
So this pull request change this interface calls.
I hope this pull request is ok, if not let me know to change it.
Thanks for your work.
Mateo