Skip to content

Commit

Permalink
providers/vmware: add missing public functions for non-amd64
Browse files Browse the repository at this point in the history
VmwareProvider must have a corresponding empty function
`parse_netplan_config()` in unsupported part as well, just like the
amd64 part.
Otherwise build would fail when cross-building afterburn for arm64.

```
error[E0599]: no method named `parse_netplan_config` found for reference
`&VmwareProvider` in the current scope
  --> src/providers/vmware/mod.rs:37:14
   |
37 |         self.parse_netplan_config()
   |              ^^^^^^^^^^^^^^^^^^^^ method not found in
`&VmwareProvider`
```
  • Loading branch information
dongsupark committed Dec 5, 2023
1 parent 12dc7b9 commit 13f3dd5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions docs/release-notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Major changes:

Minor changes:

- providers/vmware: add missing public functions for non-amd64

Packaging changes:

Expand Down
4 changes: 4 additions & 0 deletions src/providers/vmware/unsupported.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,8 @@ impl VmwareProvider {
pub fn try_new() -> Result<Self> {
bail!("unsupported architecture");
}

pub fn parse_netplan_config(&self) -> Result<Option<String>> {
bail!("unsupported architecture");
}
}

0 comments on commit 13f3dd5

Please sign in to comment.