Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxmoxve: do not fail if the config drive does not exist #1128

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

tormath1
Copy link
Contributor

@tormath1 tormath1 commented Nov 6, 2024

ProxmoxVE provider will fail to be created if the config drive is not available. In this PR, we add a NoopProvider that is being used in such a case to avoid Afterburn to panic.

This has been tested on Flatcar (flatcar/Flatcar#1573 (reply in thread))

Closes: #1126

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@tormath1 tormath1 marked this pull request as ready for review November 7, 2024 10:37
Copy link
Contributor

@prestist prestist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I dont see anything that needs changes.

Thank you for your contribution!

@prestist prestist merged commit 1b6a3b8 into coreos:main Dec 3, 2024
9 checks passed
@tormath1 tormath1 deleted the tormath1/proxmox branch December 5, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProxmoxVE instance fails to boot if no config drive is configured
2 participants