Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model: Add tracking of our own static config versions #609

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

cgwalters
Copy link
Member

Currently our static configs don't directly support updates. (They really should)

We also have a use case around simply introspecting the state that static configs were enabled (xref ostreedev/ostree#3150) where we want to have ostree not run grub2-mkconfig in this case.

In preparation for both of these things, add tracking of our own version of the static configs into the metadata.

In theory of course, static configs could include other components (ignition, greenboot, etc.) and we should track those too. For now this at least gets us basic metadata.

Currently our static configs don't directly support updates.
(They really should)

We also have a use case around simply introspecting the state
that static configs were enabled (xref ostreedev/ostree#3150)
where we want to have ostree not run grub2-mkconfig in this case.

In preparation for both of these things, add tracking of
our *own* version of the static configs into the metadata.

In theory of course, static configs could include other components
(ignition, greenboot, etc.) and we should track those too.  For
now this at least gets us basic metadata.
Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmarrero jmarrero merged commit 3464b3d into coreos:main Jan 31, 2024
9 checks passed
@jlebon
Copy link
Member

jlebon commented Mar 12, 2024

This broke FCOS stable builds because we currently incorrectly use the bootupd from cosa instead of the one from the target system to bootupctl backend install. v0.2.18 will write this field, even if it's null, but v0.2.17 will hard error trying to deserialize it back.

(Obviously the fix here is on the cosa side, but just noting for posterity and for something to link to.)

jlebon added a commit to coreos/coreos-assembler that referenced this pull request Mar 12, 2024
We currently use `bootupctl backend install` using the bootupd from cosa
instead of the one from the target system. Newer bootupd assumes that's
not the case. For more details, see:

coreos/bootupd#609 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants