Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if partition number 0 specified with label from default OS image #243

Closed
bgilbert opened this issue Jun 8, 2021 · 0 comments · Fixed by #279
Closed

Warn if partition number 0 specified with label from default OS image #243

bgilbert opened this issue Jun 8, 2021 · 0 comments · Fixed by #279
Labels
enhancement New feature or request good first issue Good for newcomers jira

Comments

@bgilbert
Copy link
Contributor

bgilbert commented Jun 8, 2021

If the user specifies this:

storage:
  disks:
    - device: /dev/sda
      partitions:
        - number: 0
          label: root
          size_mib: 12000
          resize: true

they probably meant number: 4. The above will create an additional partition labeled root, rather than resizing the existing one. See coreos/ignition#1219 for details.

Add FCOS validation to check for default partlabels (root, boot, EFI-SYSTEM, BIOS-BOOT, etc.) and warn if the partition number is 0. This is a reasonable warning even if we're not partitioning the boot disk, since udev can only create one partition symlink per partlabel for the whole system, and the user can easily choose another label.
@bgilbert bgilbert added the enhancement New feature or request label Jun 8, 2021
@bgilbert bgilbert mentioned this issue Jun 8, 2021
Open
@bgilbert bgilbert added the good first issue Good for newcomers label Jun 9, 2021
@arithx arithx added the jira label Jun 14, 2021
sohankunkerkar added a commit to sohankunkerkar/butane that referenced this issue Sep 13, 2021
@sohankunkerkar
config/fcos: warn if partition number for root isn't correct
1c6096c 
Fixes coreos#243

This change warns if partition number for the root label is not
specified or wrongly mentioned.
sohankunkerkar added a commit to sohankunkerkar/butane that referenced this issue Sep 13, 2021
@sohankunkerkar
config/fcos: warn if partition number for root isn't correct
65ccd10 
Fixes coreos#243

This change warns if the partition number for the root label is not
specified or wrongly mentioned.
sohankunkerkar added a commit to sohankunkerkar/butane that referenced this issue Sep 13, 2021
@sohankunkerkar
config/fcos: warn if partition number for root isn't correct
b91fa5e 
Fixes coreos#243

This change warns if the partition number for the root label is not
specified or wrongly mentioned.
sohankunkerkar added a commit to sohankunkerkar/butane that referenced this issue Sep 13, 2021
@sohankunkerkar
config/fcos: warn if the partition number for root isn't correct
171b542 
Fixes coreos#243

This change warns if the partition number for the root label is not
specified or wrongly mentioned.
sohankunkerkar added a commit to sohankunkerkar/butane that referenced this issue Sep 13, 2021
@sohankunkerkar
config/fcos: warn if the partition number for root isn't correct
6dfa633 
Fixes coreos#243

This change warns if the partition number for the root label is not
specified or wrongly mentioned.
@sohankunkerkar sohankunkerkar mentioned this issue Sep 13, 2021
Merged
sohankunkerkar added a commit to sohankunkerkar/butane that referenced this issue Sep 13, 2021
@sohankunkerkar
config/fcos: warn if the partition number for root isn't correct
d13fb86 
Fixes coreos#243

This change warns if the partition number for the root label is not
specified or wrongly mentioned.
sohankunkerkar added a commit to sohankunkerkar/butane that referenced this issue Sep 15, 2021
@sohankunkerkar
config/fcos: warn if the partition number for root isn't correct
d330de2 
Fixes coreos#243

This change warns if the partition number for the root label is not
specified or wrongly mentioned.
sohankunkerkar added a commit to sohankunkerkar/butane that referenced this issue Sep 15, 2021
@sohankunkerkar
config/fcos: warn if the partition number for root isn't correct
4214306 
Fixes coreos#243

This change warns if the partition number for the root label is not
specified or wrongly mentioned.
sohankunkerkar added a commit to sohankunkerkar/butane that referenced this issue Sep 15, 2021
@sohankunkerkar
config/fcos: warn if the partition number for root isn't correct
3e3dce0 
Fixes coreos#243

This change warns if the partition number for the root label is not
specified or wrongly mentioned.
sohankunkerkar added a commit to sohankunkerkar/butane that referenced this issue Sep 16, 2021
@sohankunkerkar
config/fcos: warn if the partition number for root isn't correct
f5a61be 
Fixes coreos#243

This change warns if the partition number for the root label is not
specified or wrongly mentioned.
sohankunkerkar added a commit to sohankunkerkar/butane that referenced this issue Sep 16, 2021
@sohankunkerkar
config/fcos: warn if the partition number for root isn't correct
6b2cc2b 
Fixes coreos#243

This change warns if the partition number for the root label is not
specified or wrongly mentioned.
sohankunkerkar added a commit to sohankunkerkar/butane that referenced this issue Nov 10, 2021
@sohankunkerkar
config/fcos: warn if the partition number for root isn't correct
4bab357 
Fixes coreos#243

This change warns if the partition number for the root label is not
specified or wrongly mentioned.
sohankunkerkar added a commit to sohankunkerkar/butane that referenced this issue Nov 11, 2021
@sohankunkerkar
config/fcos: warn if the partition number for root isn't correct
46f54e3 
Fixes coreos#243

This change warns if the partition number for the root label is not
specified or wrongly mentioned.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers jira
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config/fcos: warn if the partition number for root isn't correct sohankunkerkar/butane
2 participants
@bgilbert @arithx