buildextend-live fails on Power in FCOS

[jcajka]

Bug Report

Environment

What operating system is being used to run coreos-assembler?
Fedora
What operating system is being assembled?
FCOS
Is coreos-assembler running in Podman or Docker?
podman
If Podman, is coreos-assembler running privileged or unprivileged?
privileged

Expected Behavior

Build passes successfully.

Actual Behavior

<snip>
Drive current: -outdev 'stdio:/srv/tmp/buildpost-live/fedora-coreos-33.20210107.dev.0-live.ppc64le.iso'
Media current: stdio file, overwriteable
Media status : is blank
Media summary: 0 sessions, 0 data blocks, 0 data, 1038g free
Added to ISO image: file '/System/Library/CoreServices/grub.elf'='/tmp/grub.VIw9kF/boot/grub/powerpc-ieee1275/core.elf'
xorriso : UPDATE :       1 files added in 1 seconds
Added to ISO image: file '/boot/grub/powerpc.elf'='/tmp/grub.VIw9kF/boot/grub/powerpc-ieee1275/core.elf'
Added to ISO image: directory '/'='/tmp/grub.VIw9kF'
xorriso : WARNING : -volid text does not comply to ISO 9660 / ECMA 119 rules
Added to ISO image: directory '/'='/srv/tmp/buildpost-live/live'
xorriso : UPDATE :     247 files added in 1 seconds
xorriso : UPDATE :  7.80% done
xorriso : UPDATE :  68.86% done
ISO image produced: 373048 sectors
Written to medium : 373048 sectors at LBA 0
Writing to 'stdio:/srv/tmp/buildpost-live/fedora-coreos-33.20210107.dev.0-live.ppc64le.iso' completed successfully.

+ isoinfo -lR -i /srv/tmp/buildpost-live/fedora-coreos-33.20210107.dev.0-live.ppc64le.iso
Traceback (most recent call last):
  File "/usr/lib/coreos-assembler/cmd-buildextend-live", line 624, in <module>
    generate_iso()
  File "/usr/lib/coreos-assembler/cmd-buildextend-live", line 571, in generate_iso
    offsets[i + 1] = file_offset_in_iso(isoinfo, fn) + offset_in_file
  File "/usr/lib/coreos-assembler/cmd-buildextend-live", line 203, in file_offset_in_iso
    raise Exception('Found {} copies of {}'.format(len(matches), filename))
Exception: Found 0 copies of isolinux.cfg
Build step 'Execute shell' marked build as failure
Finished: FAILURE

Reproduction Steps

1. Build FCOS for Power to the point of running buildextend-live

Other Information

This got introduced with the commit and it is also most probably related to the #1988. I'm not sure what is right approach to the fix, but from my naive view, it seems to be only intended/useful for UEFI targets, right?

[jlebon]

#1994

[jcajka]

Thanks, missed that.

[jcajka]

Fixed via #1994 .