Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildextend-live failing for RHCOS on Power #1988

Closed
miabbott opened this issue Jan 5, 2021 · 4 comments · Fixed by openshift/os#479
Closed

buildextend-live failing for RHCOS on Power #1988

miabbott opened this issue Jan 5, 2021 · 4 comments · Fixed by openshift/os#479
Assignees
@jlebon

Comments

@miabbott
Copy link
Member

miabbott commented Jan 5, 2021

The RHCOS Power pipeline started failing recently:

Substituting ISO kernel arguments: random.trust_cpu=on coreos.liveiso=rhcos-47.83.202101051012-0
src/config/live/zipl.prm -> /home/jenkins/agent/workspace/rhcos/rhcos-rhcos-4.7/tmp/buildpost-live/live/zipl.prm
src/config/live/isolinux/isolinux.cfg -> /home/jenkins/agent/workspace/rhcos/rhcos-rhcos-4.7/tmp/buildpost-live/live/isolinux/isolinux.cfg
src/config/live/isolinux/boot.msg -> /home/jenkins/agent/workspace/rhcos/rhcos-rhcos-4.7/tmp/buildpost-live/live/isolinux/boot.msg
src/config/live/EFI/redhat/grub.cfg -> /home/jenkins/agent/workspace/rhcos/rhcos-rhcos-4.7/tmp/buildpost-live/live/EFI/redhat/grub.cfg
Traceback (most recent call last):
  File "/usr/lib/coreos-assembler/cmd-buildextend-live", line 623, in <module>
    generate_iso()
  File "/usr/lib/coreos-assembler/cmd-buildextend-live", line 369, in generate_iso
    assert(karg_embed_area_length > len(cmdline))
AssertionError

The shortlog points to b48e428

$ git shortlog --no-merges 60e6c83a6ec7e9f67231d3cbbe3987c833eb4758..b48e4287439352f17b8ef9d304897ef995156aa6
Jonathan Lebon (1):
      buildextend-live: make default kargs file look the same

cc: @jlebon @ravanelli
@jlebon jlebon self-assigned this Jan 5, 2021
jlebon added a commit to jlebon/os that referenced this issue Jan 5, 2021
@jlebon
live: add karg embed areas in GRUB/ISOLINUX configs
dc3a720 
(Copied from coreos/fedora-coreos-config#545.)

This provides a buffer into which `coreos-installer iso embed-kargs` can
write additional kernel arguments for the live ISO. It must be located
right after the karg line in configuration files.

Note this doesn't touch `zipl.prm`, which is where ISO kernel args are
stored for s390x. Supporting this for s390x would need more
investigation and testing.

Closes: coreos/coreos-assembler#1988
@jlebon jlebon mentioned this issue Jan 5, 2021
Merged
@jlebon
Copy link
Member

jlebon commented Jan 5, 2021

Ahh yeah, that cosa commit assumes there is at least one file in the live/ dirs of the src config with a karg embed area. Could tweak that, though we do want it in RHCOS too eventually anyway: openshift/os#479.

@Prashanth684
Copy link
Contributor

same for Z too...is there a way to workaround this for Z until a real fix is investigated?

@jlebon
Copy link
Member

jlebon commented Jan 5, 2021

same for Z too...is there a way to workaround this for Z until a real fix is investigated?

Z should also be fixed by openshift/os#479, even if it doesn't make use of those files. (This matches how it is in FCOS right now.)

Still, I'll also clean up the logic in cosa so it no-ops if no files have embed areas.

@jlebon
Copy link
Member

jlebon commented Jan 5, 2021

Still, I'll also clean up the logic in cosa so it no-ops if no files have embed areas.

This is part of #1989.

@jcajka jcajka mentioned this issue Jan 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlebon jlebon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

live: add karg embed areas in GRUB/ISOLINUX configs jlebon/os
3 participants
@Prashanth684 @miabbott @jlebon