create_disk: Ensure filesystem journal on rootfs is clean #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to get osmet to work with RHCOS, I kept being unable to mount the rootfs and it turned out that while the code I'd added to unpack the LUKS bits was working fine, mounting the rootfs was failing because the block device was read-only, but XFS wanted to replay the journal. And for some reason I haven't traced through yet, this apparently isn't affecting FCOS, but the unclean journal is breaking osmet w/RHCOS. This of course is the *second* time I've hit this problem of "ext4 flushes the journal on umount, XFS doesn't" - see also ostreedev/ostree#1049 Adding the necessary invocation of `xfs_freeze` ensures that our firstboot has a clean XFS journal for `/` which is just a good idea anyways.
Answer: It's not really this, it's that I wasn't making the dm-linear blockdev readonly, so XFS thought it had a writable blockdev but it really didn't. But still, we should have our filesystems mount cleanly to start. |
lucab
reviewed
May 27, 2020
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, lucab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to get osmet to work with RHCOS, I kept being unable to
mount the rootfs and it turned out that while the code I'd added
to unpack the LUKS bits was working fine, mounting the rootfs
was failing because the block device was read-only, but XFS
wanted to replay the journal.
And for some reason I haven't traced through yet, this apparently
isn't affecting FCOS, but the unclean journal is breaking osmet
w/RHCOS.
This of course is the second time I've hit this problem of
"ext4 flushes the journal on umount, XFS doesn't" - see
also ostreedev/ostree#1049
Adding the necessary invocation of
xfs_freezeensuresthat our firstboot has a clean XFS journal for
/whichis just a good idea anyways.