Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Fedora 33 #1881

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Move to Fedora 33 #1881

merged 1 commit into from
Dec 4, 2020

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Nov 18, 2020

It's in testing now, and the blocker that was preventing us from moving
is gone (see #1496).

It's in testing now, and the blocker that was preventing us from moving
is gone (see coreos#1496).
@jlebon
Copy link
Member Author

jlebon commented Nov 18, 2020

Still testing this myself.
We should probably do a release before merging this.
/hold

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@cgwalters
Copy link
Member

I think this also blocks on #1863

@jlebon
Copy link
Member Author

jlebon commented Nov 30, 2020

Blocked on #1896.

@cgwalters
Copy link
Member

/hold cancel

@dustymabe
Copy link
Member

discussed with jlebon in IRC. We're going to hold until the releases get out. Should be able to merge on Thursday.

/hold

@jlebon
Copy link
Member Author

jlebon commented Dec 4, 2020

We're holding the stable release for now.

Let's unhold this one. I'll cut a release, then we can merge it. For the stable release, we can use the freshly cut cosa release.

/hold cancel

@dustymabe
Copy link
Member

Let's unhold this one. I'll cut a release, then we can merge it. For the stable release, we can use the freshly cut cosa release.

👍

@jlebon
Copy link
Member Author

jlebon commented Dec 4, 2020

Release cut: https://github.com/coreos/coreos-assembler/releases/tag/v0.10.0
This is ready to go now!

@dustymabe
Copy link
Member

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit df833ad into coreos:master Dec 4, 2020
@jlebon jlebon deleted the pr/f33 branch April 22, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants