mantle/platform: rename IgnitionNetworkKargs to AppendFirstbootKernelArgs and expose to ext tests #2683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dustymabe
commented
Feb 2, 2022
dustymabe
commented
…Args We want to expose this to external tests and AppendFirstbootKernelArgs is a bit more explicit about what it's doing, which is applying kernel arguments that will apply to only the first boot of the machine.
This is a little more inline with what's being done, which is to apply the given arguments to the first boot of the machine only.
Add the ability to specify firstboot kernel arguments to transiently append to the default kernel arguments for the first boot of the machine. This will be useful when testing workflows that use kernel arguments for network configuration. For now, this only supports the qemu platform.
dustymabe
changed the title
jlebon
approved these changes
Feb 2, 2022
| @@ -75,7 +75,7 @@ const maxAdditionalNics = 16 | |||
|
|
|||
| func init() { | |||
| root.AddCommand(cmdQemuExec) | |||
| cmdQemuExec.Flags().StringVarP(&knetargs, "knetargs", "", "", "Arguments for Ignition networking on kernel commandline") | |||
| cmdQemuExec.Flags().StringVarP(&firstbootkargs, "firstbootkargs", "", "", "Additional first boot kernel arguments") | |||
There was a problem hiding this comment.
ehh - i'm not in love with either way. I kept no dashes since knetargs didn't have one either.
There was a problem hiding this comment.
If this passes CI I'll merge it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.