Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mantle: switch back to RSA SSH keys #2760

Merged
merged 3 commits into from
Mar 17, 2022
Merged

mantle: switch back to RSA SSH keys #2760

merged 3 commits into from
Mar 17, 2022

Conversation

bgilbert
Copy link
Contributor

golang.org/x/crypto/ssh finally supports RSA SHA-2 signatures, so we can drop our workarounds for Fedora crypto policy forbidding RSA SHA-1.

Fixes #1772. Reverts ac54a8a, db56cfe, and a2066db.

golang.org/x/crypto/ssh finally supports RSA SHA-2 signatures, so we can
drop our workarounds for Fedora crypto policy forbidding RSA SHA-1.

Fixes #1772.  Reverts ac54a8a, db56cfe, and a2066db.
@bgilbert bgilbert requested a review from dustymabe March 16, 2022 19:56
@bgilbert
Copy link
Contributor Author

Tested on QEMU and AWS, not on Azure.

@dustymabe
Copy link
Member

Thank you for this!

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bgilbert bgilbert merged commit dcd432d into coreos:main Mar 17, 2022
@bgilbert bgilbert deleted the rsa branch March 17, 2022 03:50
@jlebon
Copy link
Member

jlebon commented Mar 18, 2022

Possible fallout in rpm-ostree CI: coreos/rpm-ostree#3528 (comment)

@jlebon
Copy link
Member

jlebon commented Mar 18, 2022

Follow-up in #2765.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kola: support for ssh RSA key types other than RSA-SHA1
3 participants