Add support for composefs #3483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
enable-ostree-composefs
branch
from
d46ce9e to
2398866
Compare
|
jenkins flaked on a kola test, and not sure what happened with the prow one |
|
Still not sure what's going on with the prow timeouts |
cgwalters
force-pushed
the
enable-ostree-composefs
branch
from
2398866 to
710cc0a
Compare
|
This mostly LGTM but it would be nice to have a general design document to clarify how all of this will interact as there are currently no documentation as far as I could see. |
|
I've created ostreedev/ostree#2867 as an initial doc (please feel free to edit). |
cgwalters
force-pushed
the
enable-ostree-composefs
branch
from
710cc0a to
d8e342b
Compare
|
/retest |
cgwalters
force-pushed
the
enable-ostree-composefs
branch
from
d8e342b to
75b7bdf
Compare
This pairs with ostreedev/ostree#2640 It's all off by default (to state the obvious). But one can do e.g.: ``` $ cat >> src/config/image.yaml << EOF composefs: true EOF ``` To test out the fsverity bits, you also want `rootfs: ext4verity` More in ostreedev/ostree#2867
cgwalters
force-pushed
the
enable-ostree-composefs
branch
from
75b7bdf to
004bc47
Compare
|
OK, per the recent direction in ostree upstream we will be directly reusing the existing ostree signature support, which means we can just drop all things related to signing and keys from this code. Now this option boils down to enabling a documented repo flag. |
|
/retest |
travier
approved these changes
Jun 28, 2023
|
/retest |
|
Thanks for the nice documentation! LGTM |
|
/retest |
This was referenced Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pairs with ostreedev/ostree#2640
It's all off by default (to state the obvious). But one can do e.g.:
To test out the fsverity bits, you also want
rootfs: ext4verityMore in ostreedev/ostree#2867