koji: Add functions to check/ensure the build tag #3552
Conversation
ravanelli
force-pushed
the
brew_validate
branch
from
bad3d2d
to
1c1c315
Compare
|
/retest-required |
ravanelli
force-pushed
the
brew_validate
branch
from
1c1c315
to
44e0ed3
Compare
|
I'm still testing it /hold |
ravanelli
force-pushed
the
brew_validate
branch
2 times, most recently
from
264b38d
to
c329406
Compare
ravanelli
force-pushed
the
brew_validate
branch
from
c329406
to
1d05289
Compare
|
I made a comment over in coreos/fedora-coreos-pipeline#902 (comment) that would have implications here if we decided we wanted to make a change. |
ravanelli
force-pushed
the
brew_validate
branch
6 times, most recently
from
4cae0a6
to
a5b0478
Compare
ravanelli
force-pushed
the
brew_validate
branch
from
a5b0478
to
b1c140b
Compare
|
Still need to update the commit message. Otherwise LGTM |
- Add check_tag, to check if the tag was added to the build; - Add ensure_tag, if the tag is not part of the build, add it. Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
force-pushed
the
brew_validate
branch
from
b1c140b
to
351ae13
Compare
ravanelli
changed the title
|
@ravanelli: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Ignoring the RHCOS CI failure since this change couldn't possibly be causing a failure there. |
|
/cherry-pick rhcos-4.13 |
|
@dustymabe: new pull request created: #3565 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick rhcos-4.12 |
|
/cherry-pick rhcos-4.11 |
|
/cherry-pick rhcos-4.10 |
|
/cherry-pick rhcos-4.9 |
|
@dustymabe: new pull request created: #3566 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@dustymabe: new pull request created: #3567 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@dustymabe: new pull request created: #3568 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@dustymabe: new pull request created: #3569 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There are cases we can't tag a Brew build after the upload is finished. The tag is a different transction, causing a scenario where we have the Brew build without a tag.
For this reason we need to make sure the tag was added in build as expected. If it wasn't, we need to add the tag.