-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve kola argument processing logic for platform specific options #3752
base: main
Are you sure you want to change the base?
Conversation
Hi @itsCheithanya. Thanks for your PR. I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I think there are more options to look at to force the platform being used. Looks like this also needs code formatting. |
Please use a more descriptive commit message that notably includes at the end:
|
Yes i will add for all of them ,just wanted to know if I'm in the right direction |
Sorry i just made this PR for code clarifications not an actual issue solving one, will make sure to follow it for the coming PR's |
Yes, looks like you're going in the right direction. |
kola platform cmd logic processing
@travier As part of the backlog refinement, we came across this issue. We wanted to know if this is a relevant issue. |
Improve kola argument processing for platform-specific options
Implements logic to automatically infer the platform based on provided options for AWS, Azure, DO, ESX, GCP, OpenStack, and Packet. Ensures platform consistency when using platform-specific options (e.g., --aws-ami).
Fixes: #3509