Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve kola argument processing logic for platform specific options #3752

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

itsCheithanya
Copy link

@itsCheithanya itsCheithanya commented Mar 11, 2024

Improve kola argument processing for platform-specific options
Implements logic to automatically infer the platform based on provided options for AWS, Azure, DO, ESX, GCP, OpenStack, and Packet. Ensures platform consistency when using platform-specific options (e.g., --aws-ami).
Fixes: #3509

Copy link

openshift-ci bot commented Mar 11, 2024

Hi @itsCheithanya. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travier
Copy link
Member

travier commented Mar 11, 2024

I think there are more options to look at to force the platform being used.

Looks like this also needs code formatting.

@travier
Copy link
Member

travier commented Mar 11, 2024

Please use a more descriptive commit message that notably includes at the end:

Fixes: https://github.com/coreos/coreos-assembler/issues/3509

@itsCheithanya
Copy link
Author

I think there are more options to look at to force the platform being used.

Looks like this also needs code formatting.

Yes i will add for all of them ,just wanted to know if I'm in the right direction

@itsCheithanya
Copy link
Author

Please use a more descriptive commit message that notably includes at the end:

Fixes: https://github.com/coreos/coreos-assembler/issues/3509

Sorry i just made this PR for code clarifications not an actual issue solving one, will make sure to follow it for the coming PR's

@travier
Copy link
Member

travier commented Mar 11, 2024

Yes i will add for all of them ,just wanted to know if I'm in the right direction

Yes, looks like you're going in the right direction.

kola platform cmd logic processing
@itsCheithanya
Copy link
Author

itsCheithanya commented Mar 12, 2024

@travier
#87c8ea4
Made the required code changes for all other platform options ,Let me know if anything needs to be done

@aaradhak aaradhak requested a review from travier May 30, 2024 14:43
@aaradhak
Copy link
Member

@travier As part of the backlog refinement, we came across this issue. We wanted to know if this is a relevant issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve kola argument processing logic for platform specific options
3 participants