-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build live ISO using osbuild #3847
Conversation
We run osbuild inside of supermin, so for building the live ISO we'll need all the tools it needs in there. This includes `genisoimage` and `syslinux-nonlinux`. We don't currently name `squashfs-tools` as a toplevel dependency. It's currently pulled in by libguestfs, but we need it in supermin too, so explicitly list it there.
This adds a new osbuild pipeline for building the live ISO using the new `org.osbuild.coreos.live-iso` mega stage. Still missing is changing `cmd-buildextend-live` to call osbuild instead. I think we'll need to ratchet this in using e.g. an env var like we did for the other osbuild artifacts. E.g. `COSA_OSBUILD_LIVE` would control whether to use the old logic or the new one. And then turn it on in rawhide, etc... The new `cmd-buildextend-live` would also take care of extracting the live artifacts from the live ISO to insert into `meta.json`.
Skipping CI for Draft Pull Request. |
Requires: osbuild/osbuild#1842 |
This works locally! To test it:
And we get an |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Tested, lgtm! Thanks for working on it @jlebon! |
I also started working on: #3861 i |
This is part of #3861. |
This adds a new osbuild pipeline for building the live ISO using the new
org.osbuild.coreos.live-iso
mega stage.Still missing is changing
cmd-buildextend-live
to call osbuildinstead. I think we'll need to ratchet this in using e.g. an env var
like we did for the other osbuild artifacts. E.g.
COSA_OSBUILD_LIVE
would control whether to use the old logic or the new one. And then turn
it on in rawhide, etc...
The new
cmd-buildextend-live
would also take care of extracting thelive artifacts from the live ISO to insert into
meta.json
.