Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildextend-live: Add support OSBUILD #3861

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Commits on Oct 1, 2024

  1. deps.txt: move some deps to vmdeps.txt

    We run osbuild inside of supermin, so for building the live ISO we'll
    need all the tools it needs in there. This includes `genisoimage` and
    `syslinux-nonlinux`.
    
    We don't currently name `squashfs-tools` as a toplevel dependency. It's
    currently pulled in by libguestfs, but we need it in supermin too, so
    explicitly list it there.
    jlebon authored and ravanelli committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    147ea5c View commit details
    Browse the repository at this point in the history
  2. Build live ISO using osbuild

    This adds a new osbuild pipeline for building the live ISO using the new
    `org.osbuild.coreos.live-iso` mega stage.
    
    Still missing is changing `cmd-buildextend-live` to call osbuild
    instead. I think we'll need to ratchet this in using e.g. an env var
    like we did for the other osbuild artifacts. E.g. `COSA_OSBUILD_LIVE`
    would control whether to use the old logic or the new one. And then turn
    it on in rawhide, etc...
    
    The new `cmd-buildextend-live` would also take care of extracting the
    live artifacts from the live ISO to insert into `meta.json`.
    jlebon authored and ravanelli committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    4f5e7f7 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. cmd-buildextend-live: Move constants to file top level and standardiz…

    …e naming
    
    - Rename `ignition_img_size` to `IGNITION_IMG_SIZE`
    and `miniso_data_file_size` to `MINISO_DATA_FILE_SIZE`
    for consistent naming convention;
    - Move these definitions to the top level for better visibility and maintainability
    
    Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
    ravanelli committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    dc48a5f View commit details
    Browse the repository at this point in the history
  2. cmd-buildextend-live: Refactor variable declarations and directories …

    …creation
    
    - Moved variable declarations and directories creation into generate_iso()
      to enhance clarity and maintainability.
    
    Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
    ravanelli committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    4b076c6 View commit details
    Browse the repository at this point in the history
  3. src/cmd-buildextend-live: Refactor variable declarations

     -  Moved variable declarations to top to enhance clarity.
    
    Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
    ravanelli committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    8c53a55 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. buildextend-live: Add OSBUILD support

     - Add support for OSBUILD via COSA_OSBUILD_LIVEISO env var for now.
    Once we finish the OSBUILD integration we can disable it via var.
    
    Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
    ravanelli committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    ba12dc1 View commit details
    Browse the repository at this point in the history