Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mantle: move kolet binary location to /usr/local/bin #3888

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

dustymabe
Copy link
Member

I'm writing a test that verifies files on the filesystem in CoreOS machinges match the SELinux policy. Placing kolet in /var/home/core/kolet with a bin_t context is a violation of this. Let's use /usr/local/bin/. This has the side effect of the file having the right bin_t context as soon as it is created.

jlebon
jlebon previously approved these changes Sep 20, 2024
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, makes sense to me! I think it was just done that way to adapt to DropFile which puts it in the home dir.

I'm writing a test that verifies files on the filesystem
in CoreOS machinges match the SELinux policy. Placing
kolet in `/var/home/core/kolet` with a `bin_t` context
is a violation of this. Let's use /usr/local/bin/. This
has the side effect of the file having the right `bin_t`
context as soon as it is created.
After the last commit there are no users of this.
@dustymabe
Copy link
Member Author

ok - rebased this. should pass CI now.

@jlebon jlebon merged commit 23cdc20 into coreos:main Sep 24, 2024
5 checks passed
HuijingHei added a commit to HuijingHei/rpm-ostree that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants