mantle/kola: Add function to enhance upgrade stability #3938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the `waitForUpgradeToBeStaged` function to improve the stability of kola upgrade test by reducing timeout-related failures. The new function sets up a systemd path unit to monitor updates in the `/ostree/repo/refs/heads/ostree/1/1` directory, triggering a stop on `wait.service` once changes are detected. By ensuring we wait later in the upgrade process, we minimize the waiting period in `runFnAndWaitForRebootIntoVersion`, focusing only on the actual reboot phase. Author : Dusty Mabe <dusty@dustymabe.com> Ref: coreos/fedora-coreos-tracker#1805
jlebon
reviewed
Nov 13, 2024
| // | ||
| // Note: if systemd-run ever gains the ability to --wait when | ||
| // generating a path unit then the below can be simplified. | ||
| c.RunCmdSync(m, "sudo systemd-run -u refchanged --path-property=PathChanged=/ostree/repo/refs/heads/ostree/1/1 systemctl stop wait.service") |
There was a problem hiding this comment.
The canonical API for this is /ostree/deploy, which ostree touches whenever it changed the deployments exactly for the purpose of other things wanting to monitor changes:
There was a problem hiding this comment.
+1
so we just need to change this to path-property=PathChanged=/ostree/deploy then and update the comment accordingly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the
waitForUpgradeToBeStagedfunction to improve the stability of kola upgrade test by reducing timeout-related failures.The new function sets up a systemd path unit to monitor updates in the
/ostree/repo/refs/heads/ostree/1/1directory, triggering a stop onwait.serviceonce changes are detected.By ensuring we wait later in the upgrade process, we minimize the waiting period in
runFnAndWaitForRebootIntoVersion, focusing only on the actual reboot phase.Author : Dusty Mabe dusty@dustymabe.com
Ref: coreos/fedora-coreos-tracker#1805