cmd-build: Rename OSTree commit object #517
Conversation
Rename the OSTree commit object to `ostree-commit-object` to be more explicit. I'd like the term "OSTree commit" to refer to the whole tree.
| @@ -22,5 +22,5 @@ r.open(None) | |||
|
|
|||
| [_, rev] = r.resolve_rev(args.rev, True) | |||
| [_, commit, _] = r.load_commit(rev) | |||
| with open(args.builddir + '/ostree-commit', 'wb') as f: | |||
| with open(args.builddir + '/ostree-commit-object', 'wb') as f: | |||
There was a problem hiding this comment.
Will backcompat be a problem if we wholly rename it? Or is the idea to change the usage of the commit object entirely in #515?
There was a problem hiding this comment.
Ahh OK, so this is not used elsewhere in cosa, but is used internally in the RHCOS pipeline to prepare for the next build. So yes, the code there would have to be slightly tweaked for the rename once RHCOS inherits these changes. Though I'd like to also upstream that S3 prep logic into the buildprep command to abstract all this.
There was a problem hiding this comment.
OK, thanks for confirming my thoughts. I'm OK with this change regardless; we can limp along with rhcos-4.1 for a while (at least until OpenShift 4 GA). 😉
|
Hmm...OK, I think we may be able to do a "schema change" and copy the object in old builds. |
Sorry, not sure I follow. Are you suggesting the code here retroactively doing this translation on previous build dirs? Or are you talking about the |
|
I'm saying we write a one-off script to copy the object in old builds for RHCOS. |
👍 - I like explicit |
|
Going to merge this one. I pushed out a pull request internally to adapt to this change ahead of time. |
Rename the OSTree commit object to
ostree-commit-objectto be moreexplicit. I'd like the term "OSTree commit" to refer to the whole tree.
Split out of #515.