More prep patches for miniso work #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to make it easy to get the address both in sector or offset form without having to multiply/divide in callers. Let's just make a proper type for this.
|
OK, clearly I need to updated my local clippy. |
bgilbert
approved these changes
Sep 26, 2021
This is symmetrical to the existing `LimitReader` we already have. This will be used by the miniso code for overwriting files in the live ISO.
This is symmetrical to the existing `IsoFs::read_file` returning a `Reader`.
This will be re-used by a future patch. While we're here, clean things up so we don't call `bindcoder()` more times than necessary.
This will be re-used by a future patch.
|
Updated! |
bgilbert
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out of #559. See individual commit messages.