This repository has been archived by the owner on Sep 18, 2020. It is now read-only.
Revert "Merge pull request #2308 from sapcc/master" #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dm0-
approved these changes
Apr 24, 2017
|
@dm0- autogenerated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 14be7e8, reversing
changes made to 144812b.
See coreos/bugs#1892
Fixing that issue correctly turns out to be more complicated than expected (requiring patching rkt fly), so let's hold this fix out of stable for one more cycle.
It's better to have the state of the world before this (kubelet-wrapper boots, but doesn't have logs plumbed out unless you manually add mounts) than after (kubelet-wrapper fails to boot if you had configured logs).