Skip to content
This repository has been archived by the owner on Feb 12, 2021. It is now read-only.

golang: recommend glide instead of godep #854

Merged
merged 1 commit into from
Oct 27, 2016
Merged

Conversation

jonboulle
Copy link
Contributor

@jonboulle jonboulle commented Jul 6, 2016

fixes #775

@joshix
Copy link
Contributor

joshix commented Jul 9, 2016

LGTM as an excision of the existing and deprecated godep recommendation.

Will glide things like updating vendored deps require in-particular project guidance as they did with godep[1]? Or are the external docs fit for purpose there?

[1] #775 (comment)

@ericchiang
Copy link

I'll volunteer to write a "Using Glide" document based on my experience using it for a few projects (including Dex).

@jonboulle
Copy link
Contributor Author

@s-urbaniak we can probably pull something from here?
https://github.com/coreos/rkt/blob/master/Documentation/hacking.md#managing-dependencies

On 13 July 2016 at 07:09, Eric Chiang notifications@github.com wrote:

I'll volunteer to write a "Using Glide" document based on my experience
using it for a few projects (including Dex).


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#854 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ACewN9J664xpjzFfObQFmq4vdcqXTwD7ks5qVHLvgaJpZM4JGDyc
.

@s-urbaniak
Copy link

@jonboulle Yes, the whole "Managing dependencies" chapter actually is not rkt-specific, except that we don't "like" declaring version ranges in glide.yaml, also https://github.com/coreos/rkt/blob/master/scripts/glide-update.sh turned out to be a good starting point for other projects.

@pop
Copy link
Contributor

pop commented Oct 25, 2016

@jonboulle this looks good to me. The lack of a replacement for Using Godep seems like it might be a problem, but if the consensus is that we don't need a replacement doc this looks good to merge. 👍

@pop pop assigned pop and jonboulle Oct 25, 2016
@jonboulle jonboulle merged commit 762611b into master Oct 27, 2016
@jonboulle jonboulle deleted the jonboulle-glide branch October 27, 2016 15:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

golang: migrate to Godep alternative?
5 participants