This repository has been archived by the owner on Mar 28, 2020. It is now read-only.
doc: cluster_tls, wildcard domain correction #1403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doc: cluster_tls, wildcard domain correction based on the discussion etcd-io/etcd#8534 (comment)
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
| @@ -35,8 +35,8 @@ The example cluster YAML manifest and example certs can be found in [example/tls | |||
|
|
|||
| The peer TLS assets should have the following: | |||
| - **peer.crt**: peer communication cert. | |||
| The certificate should allow wildcard domain `*.${clusterName}.${namespace}.svc`. | |||
| In this case, it is `*.example.default.svc`. | |||
| The certificate should allow wildcard domain `*.${clusterName}.${namespace}.svc` and `*.{clusterName}.{namespace}.svc.cluster.local`. | |||
There was a problem hiding this comment.
See https://github.com/coreos/etcd-operator/blob/master/pkg/util/etcdutil/member.go#L40
After 0.5.1+, etcd operator will not have ".cluster.local" suffix in domain.
There was a problem hiding this comment.
tls was failing as the host didn't had .cluster.local suffix while creating the cert. I'll try with 0.5.2 and will let you know.
|
I don't understand why you create this PR. Can you elaborate your problem again? |
|
Closing this since it's not necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc: cluster_tls, wildcard domain correction
based on the discussion etcd-io/etcd#8534 (comment)