overlay/15fcos: coreos-check-ssh-keys: limit search to current boot #1373
Conversation
|
Code LGTM. This could probably use a comment explaining why we're explicitly checking only the current boot. Similarly, let's summarize the problem being fixed in the commit message. (Also, the correct link is coreos/fedora-coreos-tracker#1033, and it's not a Jira card. 🙂) |
|
code LGTM as well. Agree with the points benjamin made. Also might want to change the commit title to something like: |
aaradhak
changed the title
|
Hi @bgilbert @dustymabe , I have made the changed you had mentioned in the comments. Kindly provide your feedback. |
There was a problem hiding this comment.
hey @aaradhak. The commit message looks great. A few improvements:
- remove the quotation marks in the commit title
- break up lines at around 70 to 80 characters
- the last line should be something like
Fixes https://github.com/coreos/fedora-coreos-tracker/issues/1033
Also as bgilbert said. It would be good if we added this context as a comment in the code. I made the suggestion inline in the code to show you what we mean.
aaradhak
force-pushed
the
fedoraduar
branch
2 times, most recently
from
bcdbfb7
to
2155f2f
Compare
|
LGTM - let's squash these down to a single commit. |
On re-provisioning a FCOS instance, Ignition will append notices like "wrote ssh authorized keys file for user: %s" to "/etc/issue.d/30_ssh_authorized_keys.issue". The problem is that the journal from the previous install remains available and multiple entries are displayed when the journal is searched. The problem is fixed by limiting the journal output to the most recent boot. Fixes coreos/fedora-coreos-tracker#1033
|
Yes, the commits are git squashed now.
|
fixed the problem by limiting the journal output to the most recent boot - jira #1033