Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop modularity support/tests #2508

Merged

Conversation

dustymabe
Copy link
Member

In Fedora 39 modularity is going away [1]. Let's drop the repos for F39+ and also drop the test that we have. We do still want to test installing crio works so let's add crio to the ext.config.extensions.package test.

[1] https://fedoraproject.org/wiki/Changes/RetireModularity

marmijo
marmijo previously approved these changes Jul 14, 2023
Copy link
Member

@marmijo marmijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two small nits

manifests/fedora-repos-modular.yaml Outdated Show resolved Hide resolved
manifests/fedora-coreos.yaml Outdated Show resolved Hide resolved
In Fedora 39 modularity is going away [1]. Let's drop the repos for F39+
and also drop the test that we have. We do still want to test installing
crio works so let's add crio to the ext.config.extensions.package test.

We also drop the repos as input to the build here. They were never used
for actual RPM content anyway.

[1] https://fedoraproject.org/wiki/Changes/RetireModularity
@dustymabe dustymabe enabled auto-merge (rebase) July 15, 2023 12:30
@dustymabe dustymabe disabled auto-merge July 15, 2023 13:58
@dustymabe dustymabe merged commit ff1a047 into coreos:testing-devel Jul 15, 2023
@dustymabe dustymabe deleted the dusty-drop-modular-support branch July 15, 2023 13:58
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this pull request Jul 15, 2023
We deleted the test in coreos#2508
so we have no need for the denial any longer.

Closes coreos/fedora-coreos-tracker#1526
gursewak1997 pushed a commit that referenced this pull request Jul 16, 2023
We deleted the test in #2508
so we have no need for the denial any longer.

Closes coreos/fedora-coreos-tracker#1526
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this pull request Oct 10, 2023
We deleted the test in coreos#2508
so we have no need for the denial any longer.

Closes coreos/fedora-coreos-tracker#1526
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this pull request Oct 10, 2023
We deleted the test in coreos#2508
so we have no need for the denial any longer.

Closes coreos/fedora-coreos-tracker#1526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants