-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop modularity support/tests #2508
Merged
dustymabe
merged 1 commit into
coreos:testing-devel
from
dustymabe:dusty-drop-modular-support
Jul 15, 2023
Merged
Drop modularity support/tests #2508
dustymabe
merged 1 commit into
coreos:testing-devel
from
dustymabe:dusty-drop-modular-support
Jul 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustymabe
force-pushed
the
dusty-drop-modular-support
branch
from
July 14, 2023 20:26
f8ebdbf
to
8ecd58c
Compare
This was referenced Jul 14, 2023
dustymabe
force-pushed
the
dusty-drop-modular-support
branch
from
July 14, 2023 21:58
8ecd58c
to
5067df9
Compare
marmijo
previously approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with two small nits
In Fedora 39 modularity is going away [1]. Let's drop the repos for F39+ and also drop the test that we have. We do still want to test installing crio works so let's add crio to the ext.config.extensions.package test. We also drop the repos as input to the build here. They were never used for actual RPM content anyway. [1] https://fedoraproject.org/wiki/Changes/RetireModularity
dustymabe
force-pushed
the
dusty-drop-modular-support
branch
from
July 15, 2023 12:29
5067df9
to
9c2894a
Compare
dustymabe
added a commit
to dustymabe/fedora-coreos-config
that referenced
this pull request
Jul 15, 2023
We deleted the test in coreos#2508 so we have no need for the denial any longer. Closes coreos/fedora-coreos-tracker#1526
gursewak1997
pushed a commit
that referenced
this pull request
Jul 16, 2023
We deleted the test in #2508 so we have no need for the denial any longer. Closes coreos/fedora-coreos-tracker#1526
HuijingHei
pushed a commit
to HuijingHei/fedora-coreos-config
that referenced
this pull request
Oct 10, 2023
We deleted the test in coreos#2508 so we have no need for the denial any longer. Closes coreos/fedora-coreos-tracker#1526
HuijingHei
pushed a commit
to HuijingHei/fedora-coreos-config
that referenced
this pull request
Oct 10, 2023
We deleted the test in coreos#2508 so we have no need for the denial any longer. Closes coreos/fedora-coreos-tracker#1526
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Fedora 39 modularity is going away [1]. Let's drop the repos for F39+ and also drop the test that we have. We do still want to test installing crio works so let's add crio to the ext.config.extensions.package test.
[1] https://fedoraproject.org/wiki/Changes/RetireModularity