platforms: [qemu] Also use hvc0 for x86_64/aarch64 #2785
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pairs with coreos/coreos-assembler#3689
Basically hvc0 is faster and more modern, but requires us to opt-in specifically. We already had a few usages of hvc0 from cloud providers that default to this, no reason for us not to do it for our own qemu provider.
(One thing TODO here: I believe s390x qemu could do this too;
as of right now we don't have any references to s390x here)