-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/kola: adding the external kola test for luks + multipath case #3124
base: testing-devel
Are you sure you want to change the base?
tests/kola: adding the external kola test for luks + multipath case #3124
Conversation
a305f0c
to
178e930
Compare
CI is hitting:
We need to update the logic here to instead be something like (pseudo-code):
|
178e930
to
a19c7d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the original bug was against PowerPC, can you verify that it also passes there?
if grep -q "rd.multipath=default" /proc/cmdline; then | ||
if ! systemctl cat boot.mount | grep -q "What=/dev/disk/by-label/dm-mpath-boot"; then | ||
systemctl cat boot.mount | ||
fatal "boot is not mounted by /dev/disk/by-label/dm-mpath-boot" | ||
fi | ||
ok "boot mounted from /dev/disk/by-label/dm-mpath-boot" | ||
else | ||
if ! systemctl cat boot.mount | grep -q "What=/dev/disk/by-uuid"; then | ||
systemctl cat boot.mount | ||
fatal "boot is not mounted by UUID as expected" | ||
fi | ||
ok "boot mounted by UUID" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good candidate to dedupe. E.g. something like
if grep ...; then
expected_what=/dev/disk/by-label/dm-mpath-boot
else
expected_what=/dev/disk/by-uuid
fi
if ! systemctl cat ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the changes as per the above suggestion.
a19c7d0
to
dd5c4e9
Compare
Yes, I have tested it on PowerPC and it got passed.
|
dd5c4e9
to
d52cfb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment, but LGTM as is too.
Thanks for working on this!
## kola: | ||
## # This test reprovisions the rootfs. | ||
## tags: "reprovision" | ||
## # This uses additionalDisks, which is QEMU only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is incorrect. It's more like:
## # This uses additionalDisks, which is QEMU only | |
## # This uses appendKernelArgs and multipath, which is QEMU only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, updated it.
4c39fda
to
79a976b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just one final sanity-check: did you test this on both RHCOS and FCOS?
I tested this only on FCOS as the RHCOS having issues in boot( Shell i build the RHCOS image with custom coreos-installer and try this out.? |
Ahh indeed. We're still on v0.21.0 there for some reason. Will inquire about that. |
67b6c23
to
74efa3f
Compare
I just tested the RHCOS with latest build and it got booted and the external kola luks+multipath test case got passed.
RHCOS kola test logs forluks+multipath:
However FCOS, which was previously functional, is now failing to boot as it is throwing the below error.
FCOS console logs :
|
74efa3f
to
8fc820b
Compare
Hmm, definitely odd. This might be some weird udev issue. And this used to pass... so possibly some race that became more racy? Not sure. I would try to reproduce this manually (do a |
Signed-off-by: Poorna Gottimukkula <Poorna.Gottimukkula1@ibm.com>
8fc820b
to
e42329b
Compare
I have manually reproduced this issue using below commands with the same ignition file.
However, it is booted successfully with the below config.
|
@dustymabe I have run the coreos-builds-bisect.py with stable and testing-devel builds and found the failure introduced build. With
With
|
That represents this diff:
|
Adding the external kola test for luks + multipath validation
ref: https://issues.redhat.com/browse/OCPBUGS-13123
coreos/fedora-coreos-tracker#1728