Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dracut/firstboot-network: add default network kargs #362

Merged
merged 2 commits into from
May 12, 2020
Merged

dracut/firstboot-network: add default network kargs #362

merged 2 commits into from
May 12, 2020

Conversation

lucab
Copy link
Contributor

@lucab lucab commented Apr 21, 2020

This adds the default kargs for firstboot networking, currently mirroring
the ones configured in GRUB.

Ref: coreos/fedora-coreos-tracker#460
Required by: coreos/coreos-assembler#1373
Required by: coreos/afterburn#390

@lucab lucab mentioned this pull request Apr 21, 2020
Merged
@lucab
Copy link
Contributor Author

lucab commented Apr 21, 2020

@dustymabe FYI this renames and reuses your dracut module. Is that ok or does this disrupt other things?

@dustymabe
Copy link
Member

@dustymabe FYI this renames and reuses your dracut module. Is that ok or does this disrupt other things?

I think that's fine.

@lucab lucab force-pushed the ups/firstboot-network branch from 5ac8aef to 6e133ec Compare April 22, 2020 08:02
@lucab
Copy link
Contributor Author

lucab commented Apr 22, 2020

Amended.

jlebon
jlebon approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dustymabe
Copy link
Member

We discussed this in last weeks community meeting. I think we need to hold this until the next round of releases goes out if I recall correctly.

@dustymabe dustymabe added the hold label May 4, 2020
dustymabe
dustymabe approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucab
Copy link
Contributor Author

lucab commented May 4, 2020 •
edited
Loading

@dustymabe the one that needs to be hold till the last step is coreos/coreos-assembler#1373 (it's already marked as such). The one here is the first piece to be merged on our path.

EDIT: nevermind, we don't have to wait for merging this (i.e. it won't break other stuff), but we decided to finish the next round of releases first before proceeding.

lucab added 2 commits May 5, 2020 10:29
@lucab
overlay/core: rename firstboot-network dracut module
ddfadbc 
This repurposes the dracut module as an umbrella for all firstboot
network configuration fragments.
@lucab
dracut/firstboot-network: add default network kargs
23d12ab 
This add the default kargs for firstboot networking, currently mirroring
the ones configured in GRUB.
@lucab lucab force-pushed the ups/firstboot-network branch from 6e133ec to 23d12ab Compare May 5, 2020 10:30
@lucab
Copy link
Contributor Author

lucab commented May 11, 2020

@dustymabe is there anything else keeping it on hold at this point?

@lucab
Copy link
Contributor Author

lucab commented May 12, 2020

Round of releases done, un-holding and merging.

@lucab lucab removed the hold label May 12, 2020
@lucab lucab merged commit d510b87 into coreos:testing-devel May 12, 2020
@lucab lucab deleted the ups/firstboot-network branch May 12, 2020 13:34
@dustymabe
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustymabe dustymabe dustymabe approved these changes

@jlebon jlebon jlebon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucab @dustymabe @jlebon