-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-notes.d: initial directory for release note yaml snippets #550
base: testing-devel
Are you sure you want to change the base?
Conversation
a4d1ade
to
37fa092
Compare
37fa092
to
91af010
Compare
Updated with a |
I think there might be too much collision there. For example, what if I have a significant bugfix in Ignition? I think we have two options here:
For |
Updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - nice work @zonggen
5dd0b31
to
978608f
Compare
Maybe let's squash the two commits into one? |
@dustymabe I formatted the doc a little bit and added an example for the intermediate |
e40f419
to
cc204ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename README
to README.md
so GitHub will format the file?
cc204ef
to
ec69f0c
Compare
Simplified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I think we'll need to also do this for next-devel
?
Will having the |
@dustymabe Yes, I was writing the releng code such that:
|
Will open another PR to EDIT: Opened #570 |
This directory stores the Fedora CoreOS release note yaml snippets which will be picked up by `fedora-coreos-releng-automation/coreos-release-note-generator` [1] script to produce the final `release-notes.yaml` for a release. Related: coreos/fedora-coreos-tracker#194 Signed-off-by: Allen Bai <abai@redhat.com>
ec69f0c
to
d33a89e
Compare
faq: Link to `single` docs from FCOS
This directory stores the Fedora CoreOS release note yaml snippets which will be picked up by
fedora-coreos-releng-automation/coreos-release-note-generator
[1] script to produce the finalrelease-notes.yaml
for a release.Release notes will be organized according to the origin of the change, i.e. the project name. Otherwise miscellaneous changes will be stored under
miscellaneous
. Therefore, the schema of each yaml snippet is designed as follows:[1] https://github.com/coreos/fedora-coreos-releng-automation
Related: coreos/fedora-coreos-tracker#194
Signed-off-by: Allen Bai abai@redhat.com