Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-notes.d: initial directory for release note yaml snippets #550

Open
wants to merge 1 commit into
base: testing-devel
Choose a base branch
from

Conversation

zonggen
Copy link
Member

@zonggen zonggen commented Aug 7, 2020

This directory stores the Fedora CoreOS release note yaml snippets which will be picked up by fedora-coreos-releng-automation/coreos-release-note-generator [1] script to produce the final release-notes.yaml for a release.

Release notes will be organized according to the origin of the change, i.e. the project name. Otherwise miscellaneous changes will be stored under miscellaneous. Therefore, the schema of each yaml snippet is designed as follows:

# Each yaml file consists of a list of dictionaries which looks like this
- component (required): [Custom Project Name] | miscellaneous
  subject (required): xxx
  body (optional): xxxxx

[1] https://github.com/coreos/fedora-coreos-releng-automation

Related: coreos/fedora-coreos-tracker#194
Signed-off-by: Allen Bai abai@redhat.com

release-notes.d/README Outdated Show resolved Hide resolved
@zonggen
Copy link
Member Author

zonggen commented Aug 17, 2020

Updated with a component field instead of enforcing naming convention. Currently thought on component is to support four types of components: [Custom Project Name] | general | bugfix | security.

@dustymabe
Copy link
Member

Updated with a component field instead of enforcing naming convention. Currently thought on component is to support four types of components: [Custom Project Name] | general | bugfix | security.

I think there might be too much collision there. For example, what if I have a significant bugfix in Ignition? I think we have two options here:

  1. add a type: field with options like enhancement | bugfix | security.
  2. just ignore type: for now and add it later

For component: maybe the word miscellaneous would be better than general. So our options would be component_name | miscellaneous.

@zonggen
Copy link
Member Author

zonggen commented Aug 18, 2020

Updated the component to allow either [Project Name] or miscellaneous.

release-notes.d/README Outdated Show resolved Hide resolved
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice work @zonggen

@dustymabe
Copy link
Member

Maybe let's squash the two commits into one?

@zonggen
Copy link
Member Author

zonggen commented Aug 18, 2020

@dustymabe I formatted the doc a little bit and added an example for the intermediate release-notes.yaml file that consists a next-release field (https://github.com/coreos/fedora-coreos-config/pull/550/files#diff-501cdb98b3adaa694d31c5775aa02a46R14-R29), could you take another look?

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename README to README.md so GitHub will format the file?

release-notes.d/README Outdated Show resolved Hide resolved
@zonggen
Copy link
Member Author

zonggen commented Aug 19, 2020

Simplified README.md and squashed commits.

dustymabe
dustymabe previously approved these changes Aug 19, 2020
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I think we'll need to also do this for next-devel?

@dustymabe
Copy link
Member

Will having the example.yaml file make things harder in the implementation? Were you planning to just ignore that file in the code? I like having it there so people can copy and paste, but want to make sure we account for it.

@zonggen
Copy link
Member Author

zonggen commented Aug 20, 2020

Were you planning to just ignore that file in the code?

@dustymabe Yes, I was writing the releng code such that:

  • empty files are ignored
  • note item with empty component / subject is ignored (since they are required fields)
  • empty body is removed to clean up the final release note

@zonggen
Copy link
Member Author

zonggen commented Aug 20, 2020

Will open another PR to next-devel, thanks for the reminder!

EDIT: Opened #570

This directory stores the Fedora CoreOS release note yaml snippets which will be picked up by
`fedora-coreos-releng-automation/coreos-release-note-generator` [1] script to produce the final
`release-notes.yaml` for a release.

Related: coreos/fedora-coreos-tracker#194
Signed-off-by: Allen Bai <abai@redhat.com>
c4rt0 pushed a commit to c4rt0/fedora-coreos-config that referenced this pull request Mar 27, 2023
faq: Link to `single` docs from FCOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants