tests/kola/chrony: add test to verify the DHCP propagation of NTP servers

[sohankunkerkar]

Writing this test to verify #412 to enable the DHCP propagation of NTP servers.
CI won't pass because it needs #412 and #543

[dustymabe]

2020-08-20T20:52:57Z kola: Found non-executable file with shebang: chronydhcp

Thanks @kelvinfan001 for writing that helpful check.

@sohankunkerkar you need to make the file executable.

[dustymabe]

regarding the files: since we're re-using the chrony directory, let's move the kola.json content (which limits the platforms) into the other file and also rename it to something more appropriate. Maybe coreos-platform-chrony-generator?

If we do this I would do it in a separate commit in this PR before adding your file, which maybe we should just rename to dhcp-propagation, so the name of the test would be ext.config.chrony.dhcp-propagation.

[dustymabe]

Nice work Sohan! One final thing and then I think this will be ready for merge!

Can you also indent the code within the test_setup() function. The only part of that function that won't be indented is the heredoc; the cat <<EOF >Dockerfile would be indented, but all other lines up to and including the closing EOF would not be indented.

[sohankunkerkar]

the cat <<EOF >Dockerfile would be indented, but all other lines up to and including the closing EOF would not be indented.

Yeah, I was having the same issue yesterday that's why I didn't indent the entire test_setup() function. How about know?
Does that look any better?

[dustymabe]

LGTM

The CI tests are failing (this is a good thing). So I'll focus on review for #412 and #543 and then we'll circle back here for merge.

[dustymabe]

ok - re-kicked CI now that #412 and #543 are in.

[dustymabe]

From CI:

--- PASS: ext.fedora-coreos-config_PR-569-SVYAZ36FP6NF4RKSEFPAEHHD4SF2WAUCIV2BDXEVQBDY5X7I3W3A.chrony.dhcp-propagation (132.24s)

🎉🎉🎉