Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: adjust live RAM requirements #196

Merged
merged 1 commit into from
Oct 26, 2020
Merged

*: adjust live RAM requirements #196

merged 1 commit into from
Oct 26, 2020

Conversation

bgilbert
Copy link
Contributor

Require 2 GiB of RAM for live PXE. Live ISO no longer has any unusual RAM requirements, so drop the caveat entirely.

Per coreos/fedora-coreos-tracker#407 (comment) and coreos/fedora-coreos-tracker#407 (comment).

@dustymabe
Copy link
Member

one caveat here. In coreos/fedora-coreos-tracker#407 (comment) I did mention that I can run fine with 2iG if I use the coreos.live.rootfs_url arg. If I combine the rootfs with the initramfs to make a fat initramfs I needed more than 2GiB (2400MiB seemed to be the magic number). With 2GiB I get:

[!!!!!!] Failed to isolate default target.
[    1.338876] systemd[1]: Freezing execution.

@bgilbert
Copy link
Contributor Author

Ah, okay, I had understood from coreos/fedora-coreos-tracker#407 (comment) that that was not the case.

@bgilbert bgilbert marked this pull request as draft October 19, 2020 14:51
@dustymabe
Copy link
Member

Ah, okay, I had understood from coreos/fedora-coreos-tracker#407 (comment) that that was not the case.

Yeah, I think the requirement may have increased slightly since then.

@travier travier self-requested a review October 20, 2020 08:30
Require 2 GiB of RAM for live PXE if using coreos.live.rootfs_url and
3 GiB if using an appended initrd.  Live ISO no longer has any unusual
RAM requirements, so drop that caveat entirely.
@bgilbert bgilbert marked this pull request as ready for review October 26, 2020 02:42
@bgilbert
Copy link
Contributor Author

Okay, I conditionalized the requirement to 2 GiB with rootfs fetching and 3 GiB with rootfs appending.

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe dustymabe merged commit c7cf395 into coreos:master Oct 26, 2020
@bgilbert bgilbert deleted the ram branch October 26, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants