-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
faq: add entry that explains SSH crypto change in F33 #220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions, but LGTM overall!
modules/ROOT/pages/faq.adoc
Outdated
@@ -336,3 +336,44 @@ systemd: | |||
|
|||
For more information see | |||
https://github.com/coreos/fedora-coreos-tracker/issues/519[the tracker issue discussion]. | |||
|
|||
== After the rebase to Fedora 33 why does my tooling that uses SSH cease to work? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about something simpler like
== After the rebase to Fedora 33 why does my tooling that uses SSH cease to work? | |
== Why does SSH stop working after upgrading to Fedora 33? |
?
modules/ROOT/pages/faq.adoc
Outdated
For example, GoLang has an https://github.com/golang/go/issues/37278[open issue] | ||
to solve this problem in the GoLang stack, but has yet to resolve the | ||
issue. This has been hit and worked around by the FCOS community in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example, GoLang has an https://github.com/golang/go/issues/37278[open issue] | |
to solve this problem in the GoLang stack, but has yet to resolve the | |
issue. This has been hit and worked around by the FCOS community in | |
For example, Go has an https://github.com/golang/go/issues/37278[open issue] | |
to solve this problem in its SSH implementation, but has yet to resolve | |
it. This has been hit and worked around by the FCOS community in |
?
modules/ROOT/pages/faq.adoc
Outdated
- https://github.com/coreos/fedora-coreos-tracker/issues/699[coreos/fedora-coreos-tracker#699] | ||
- https://github.com/coreos/coreos-assembler/issues/1772[coreos/coreos-assembler#1772] | ||
|
||
If you run into this problem and need to workaround the issue you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you run into this problem and need to workaround the issue you | |
If you run into this problem and need to work around the issue, you |
If you run into this problem and need to workaround the issue you | ||
have a few options: | ||
|
||
- Switch to a newer non-RSA key type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Switch to a newer non-RSA key type. | |
- Switch to a newer non-RSA SHA-1 key type. |
(RSA SHA-2 works, right?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RSA SHA2 keyex algo works, but using a non RSA key itself will workaround the problem entirely, which is what I'm trying to say here.
4830666
to
c8e54c2
Compare
Implemented most of your suggested changes! Thanks for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM generally.
You may hit issues if you use RSA keys and: | ||
|
||
* use an old version of the `SSH` client | ||
* use tooling/software libraries that don't support using RSA SHA2 host key signatures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"public key signatures" would be clearer, since host keys aren't involved here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the suggestion. Fix in #222
No description provided.