network: Add nmstate examples #531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @bgilbert |
Now that nmstate is part of fcos the network configuration examples should be extended with it. Signed-off-by: Enrique Llorente <ellorent@redhat.com>
qinqon
force-pushed
the
add-nmstate-network-configuration
branch
from
6f0583e to
bfab777
Compare
|
Thanks for opening this. I want to discuss the implications of this amongst the team in our meeting tomorrow. |
cathay4t
reviewed
Apr 19, 2023
| - path: /etc/nmstate/ens2.yml | ||
| mode: 0600 | ||
| contents: | ||
| inline: | |
There was a problem hiding this comment.
I think the original example are expecting a static hostname. So we can state here in nmstate like:
hostname:
config: myhost
Finally got around to discussing this. Results over in coreos/fedora-coreos-tracker#1175 (comment). I'll look at this and #536 tomorrow. |
|
I will close this since @cathay4t is taking over the task, thanks @dustymabe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that nmstate is part of fcos the network configuration examples should be extended with it.
Depends on:
Open as implementation of: