Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

use liboverdrop crate #7

Closed
wants to merge 0 commits into from
Closed

use liboverdrop crate #7

wants to merge 0 commits into from

Conversation

rfairley
Copy link
Contributor

Use the API provided by coreos/liboverdrop-rs#1.

src/config/inputs.rs Outdated Show resolved Hide resolved
@rfairley
Copy link
Contributor Author

Accidentally pushed 63f9036 to master, closing this PR. This was a simple change to adapt to the changes in the liboverdrop master - so I think it is OK not to revert it. A follow-up can be done soon to use the liboverdrop crate once published.

@rfairley rfairley deleted the use-liboverdrop branch June 13, 2019 19:09
@lucab
Copy link

lucab commented Jun 13, 2019

I guess this means we now need to release and fedora-package liboverdrop before being able to release and package this. Timewise, do you think it's fine?

@rfairley rfairley restored the use-liboverdrop branch June 13, 2019 20:12
@rfairley
Copy link
Contributor Author

Right, yes this does make packaging liboverdrop a blocker. The packaging for liboverdrop should be straightforward, but I don't want to rush work there for this. I'll revert this now - less harm done.

I did build an RPM ready go here for FCOS, but we may still want to add changes upstream (in this repo) before packaging this. Shouldn't block more changes being added based on my accidental push.

@rfairley rfairley mentioned this pull request Jun 13, 2019
@rfairley
Copy link
Contributor Author

Superseded by: #10

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants