jobs/garbage-collection: add containers #1029
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
reviewed
Sep 10, 2024
jobs/garbage-collection.Jenkinsfile
Outdated
| } | ||
| } | ||
| // containers tags and cloud artifacts can be GCed in parallel | ||
| parallel { |
There was a problem hiding this comment.
This parallel syntax is for the declarative pipeline syntax, not scripted, which is what we use here. (Yeah... it's a mess.)
In the scripted syntax, parallel takes a map of string --> closure. See other uses of parallel in this repo for comparison.
Though honestly, I'd also be totally fine to not run them in parallel. It's not really a time-sensitive job either since it's a follow-up task to the release.
There was a problem hiding this comment.
yeah I got confused by the documentation. I know it's not strictly necessary but I wanted to learn :)
I updated.
Add containers tags in the garbage collection job. These can run in parrallel without issues.
jbtrystram
force-pushed
the
gc-containers
branch
from
d0a47ba
to
94a7d95
Compare
jlebon
reviewed
Sep 13, 2024
| stage('Upload Builds JSON') { | ||
| // containers tags and cloud artifacts can be GCed in parallel | ||
| def parallelruns = [:] | ||
| parallelruns['Cloud artifacts'] { |
There was a problem hiding this comment.
Suggested change
| parallelruns['Cloud artifacts'] { | |
| parallelruns['Cloud artifacts'] = { |
| parallelruns['Container tags'] { | ||
| // get repo url from pipecfg | ||
| def registry = pipecfg.registry_repos.oscontainer.repo | ||
| pipecfg, params.STREAM, params.VERSION) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add containers tags in the garbage collection job. These can run in parrallel without issues.