jobs/sync-stream-metadata: also sync release notes #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires: coreos/fedora-coreos-streams#477 |
|
We now have coreos/fedora-coreos-streams#477 in so we should get this one in |
|
This needs to convert the YAML to JSON for the release notes. |
|
Ping @dustymabe @jlebon |
|
I've updated the code to do the conversion |
jlebon
commented
May 25, 2022
Now that we have release notes in the streams repo, convert them from YAML to JSON and sync them to S3 from which the website will fetch it just like stream metadata.
|
Probably should have another lookover before merging. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have release notes in the streams repo, also start syncing
it to S3 from which the website will fetch it just like stream metadata.
This will trigger a
stream.metadata.updatemessage even if onlyrelease notes changed. I'm not aware of any consumers of this today, but
still eventually we should probably split stream/updates/release notes
into separate messages.