Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ptp_kvm as an NTP time source on qemu when available #1433

Closed
jlebon opened this issue Mar 3, 2023 · 5 comments
Closed

Use ptp_kvm as an NTP time source on qemu when available #1433

jlebon opened this issue Mar 3, 2023 · 5 comments
Labels
kind/enhancement

Comments

@jlebon
Copy link
Member

jlebon commented Mar 3, 2023

Describe the enhancement

There's a ptp_kvm kernel module that allows the guest to be in sync with the host. There's a proposal in coreos/fedora-coreos-config#2263 to make use of it and a subproposal to make "partial use" of it (see coreos/fedora-coreos-config#2263 (comment)).

Since the PR already has all the context, please keep discussions there.

System details

No response

Additional information

No response
@coreos coreos locked and limited conversation to collaborators Mar 3, 2023
@jlebon jlebon added the meeting topics for meetings label Mar 3, 2023
@dustymabe
Copy link
Member

We discussed this in the community meeting today.

12:24:31   jlebon | #agreed we will make chrony take ptp_kvm as an additional source if
                  | it's found to be accurate enough. we will add a test verifying that
                  | this setup works.

@dustymabe dustymabe added status/decided status/pending-action Needs action and removed meeting topics for meetings labels Mar 8, 2023
@jlebon jlebon added the meeting topics for meetings label Mar 29, 2023
@dustymabe
Copy link
Member

We discussed this in the community meeting today.

12:55:27  jlebon | #agreed we will keep PEERNTP=yes on QEMU so
                 | that DHCP-provided NTP servers are still
                 | considered even if ptp_kvm is available

@dustymabe dustymabe removed the meeting topics for meetings label Mar 29, 2023
jlebon added a commit to karelvanhecke/fedora-coreos-config that referenced this issue Mar 31, 2023
@karelvanhecke @jlebon
coreos-platform-chrony-config: use ptp_kvm when available on QEMU
4b23266 
KVM supports a `ptp_kvm` kernel module which allows the guest to query
the host clock for synchronization purposes.

Configure chrony to make use of it if it's available.

Don't disable the default pool; it'll be used by chrony to determine
whether the host clock is accurate or a falseticker.

Don't disable `PEERNTP` as we do on other platforms since we
historically haven't done so on QEMU and it's possible users have been
using their own DHCP servers (e.g. dnsmasq) to feed NTP configuration.

Closes: coreos/fedora-coreos-tracker#1433

Co-authored-by: Jonathan Lebon <jonathan@jlebon.com>
jlebon added a commit to karelvanhecke/fedora-coreos-config that referenced this issue Apr 4, 2023
@karelvanhecke @jlebon
coreos-platform-chrony-config: use ptp_kvm when available on QEMU
187f57a 
KVM supports a `ptp_kvm` kernel module which allows the guest to query
the host clock for synchronization purposes.

Configure chrony to make use of it if it's available.

Don't disable the default pool; it'll be used by chrony to determine
whether the host clock is accurate or a falseticker.

Don't disable `PEERNTP` as we do on other platforms since we
historically haven't done so on QEMU and it's possible users have been
using their own DHCP servers (e.g. dnsmasq) to feed NTP configuration.

Closes: coreos/fedora-coreos-tracker#1433

Co-authored-by: Jonathan Lebon <jonathan@jlebon.com>
@dustymabe dustymabe changed the title Should the QEMU image use ptp_kvm where available by default? Use ptp_kvm as an NTP time source on qemu when available Apr 4, 2023
@dustymabe dustymabe added status/pending-testing-release Fixed upstream. Waiting on a testing release. status/pending-next-release Fixed upstream. Waiting on a next release. and removed status/decided status/pending-action Needs action labels Apr 4, 2023
@dustymabe
Copy link
Member

The fix for this went into next stream release 38.20230402.1.0. Please try out the new release and report issues.

@dustymabe
Copy link
Member

The fix for this went into testing stream release 37.20230401.2.0. Please try out the new release and report issues.

@dustymabe dustymabe added status/pending-stable-release Fixed upstream and in testing. Waiting on stable release. and removed status/pending-testing-release Fixed upstream. Waiting on a testing release. status/pending-next-release Fixed upstream. Waiting on a next release. labels Apr 6, 2023
@dustymabe
Copy link
Member

The fix for this went into stable stream release 37.20230401.3.0.

@dustymabe dustymabe removed the status/pending-stable-release Fixed upstream and in testing. Waiting on stable release. label Apr 18, 2023
c4rt0 pushed a commit to c4rt0/fedora-coreos-config that referenced this issue May 17, 2023
@karelvanhecke @jlebon @c4rt0
coreos-platform-chrony-config: use ptp_kvm when available on QEMU
11c6dc3 
KVM supports a `ptp_kvm` kernel module which allows the guest to query
the host clock for synchronization purposes.

Configure chrony to make use of it if it's available.

Don't disable the default pool; it'll be used by chrony to determine
whether the host clock is accurate or a falseticker.

Don't disable `PEERNTP` as we do on other platforms since we
historically haven't done so on QEMU and it's possible users have been
using their own DHCP servers (e.g. dnsmasq) to feed NTP configuration.

Closes: coreos/fedora-coreos-tracker#1433

Co-authored-by: Jonathan Lebon <jonathan@jlebon.com>
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
@karelvanhecke @jlebon @HuijingHei
coreos-platform-chrony-config: use ptp_kvm when available on QEMU
60e419a 
KVM supports a `ptp_kvm` kernel module which allows the guest to query
the host clock for synchronization purposes.

Configure chrony to make use of it if it's available.

Don't disable the default pool; it'll be used by chrony to determine
whether the host clock is accurate or a falseticker.

Don't disable `PEERNTP` as we do on other platforms since we
historically haven't done so on QEMU and it's possible users have been
using their own DHCP servers (e.g. dnsmasq) to feed NTP configuration.

Closes: coreos/fedora-coreos-tracker#1433

Co-authored-by: Jonathan Lebon <jonathan@jlebon.com>
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
@karelvanhecke @jlebon @HuijingHei
coreos-platform-chrony-config: use ptp_kvm when available on QEMU
9baa5c9 
KVM supports a `ptp_kvm` kernel module which allows the guest to query
the host clock for synchronization purposes.

Configure chrony to make use of it if it's available.

Don't disable the default pool; it'll be used by chrony to determine
whether the host clock is accurate or a falseticker.

Don't disable `PEERNTP` as we do on other platforms since we
historically haven't done so on QEMU and it's possible users have been
using their own DHCP servers (e.g. dnsmasq) to feed NTP configuration.

Closes: coreos/fedora-coreos-tracker#1433

Co-authored-by: Jonathan Lebon <jonathan@jlebon.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dustymabe @jlebon