Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable libostree automatic early pruning #1495

Closed
jlebon opened this issue May 17, 2023 · 5 comments
Closed

Enable libostree automatic early pruning #1495

jlebon opened this issue May 17, 2023 · 5 comments
Assignees
@dustymabe
Labels
jira for syncing to jira

Comments

@jlebon
Copy link
Member

jlebon commented May 17, 2023

libostree now supports a new feature called automatic early pruning: ostreedev/ostree#2847. This allows nodes with not enough space in /boot to store the transient third kernel and initrd to still upgrade. It will allow us to make progress on #1247, #1446, and #1467.

However, the feature is not yet enabled by default. Consider enabling it in FCOS. We may decide to enable it only on non-x86_64 to start since that's where it's most needed and then eventually enable it everywhere (and eventually hopefully we can enable it by default upstream too).
@jlebon jlebon added the meeting topics for meetings label May 17, 2023
@jlebon jlebon changed the title Enable libostree automatic early pruning in FCOS Enable libostree automatic early pruning May 17, 2023
@cgwalters
Copy link
Member

We could enable it just in next or rawhide I guess too?

@dustymabe
Copy link
Member

Informational: The ostree-2023.3-1.fc38 landed in Bodhi stable and will flow into our testing-devel stream soon.

@dustymabe
Copy link
Member

We discussed this in the community meeting today.

13:17:14* dustymabe | #agreed We'll enable ostree autopruning for aarch64 in next for 
                    | at least 3 cycles (6 weeks) then promote to testing. We'll  
                    | enable it for ppc64le right away for the streams that we decide
                    | to release ppc64le for.

@dustymabe dustymabe removed the meeting topics for meetings label May 25, 2023
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue May 25, 2023
@dustymabe
manifests: enable OSTree autopruning for ppc64le
0cbdb54 
The ppc64le arch has been blocked [1] from being fully released because
of size limitations in /boot not being able to hold 3 copies of
kernel+initramfs becaue the kernel on ppc64le isn't compressed [2].
Now that OSTree Autopruning [3] has landed let's enable it on ppc64le
to unblock ourselves.

[1] coreos/fedora-coreos-tracker#987 (comment)
[2] coreos/fedora-coreos-tracker#1247 (comment)
[3] coreos/fedora-coreos-tracker#1495
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue May 25, 2023
@dustymabe
manifests: enable OSTree autopruning for ppc64le
05fb765 
The ppc64le arch has been blocked [1] from being fully released because
of size limitations in /boot not being able to hold 3 copies of
kernel+initramfs becaue the kernel on ppc64le isn't compressed [2].
Now that OSTree Autopruning [3] has landed let's enable it on ppc64le
to unblock ourselves.

[1] coreos/fedora-coreos-tracker#987 (comment)
[2] coreos/fedora-coreos-tracker#1247 (comment)
[3] coreos/fedora-coreos-tracker#1495
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue May 26, 2023
@dustymabe
manifests: enable OSTree autopruning for ppc64le
93b1a93 
The ppc64le arch has been blocked [1] from being fully released because
of size limitations in /boot not being able to hold 3 copies of
kernel+initramfs becaue the kernel on ppc64le isn't compressed [2].
Now that OSTree Autopruning [3] has landed let's enable it on ppc64le
to unblock ourselves.

[1] coreos/fedora-coreos-tracker#987 (comment)
[2] coreos/fedora-coreos-tracker#1247 (comment)
[3] coreos/fedora-coreos-tracker#1495
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue May 26, 2023
@dustymabe
manifests: enable OSTree autopruning for ppc64le
4ee0ae7 
The ppc64le arch has been blocked [1] from being fully released because
of size limitations in /boot not being able to hold 3 copies of
kernel+initramfs becaue the kernel on ppc64le isn't compressed [2].
Now that OSTree Autopruning [3] has landed let's enable it on ppc64le
to unblock ourselves.

[1] coreos/fedora-coreos-tracker#987 (comment)
[2] coreos/fedora-coreos-tracker#1247 (comment)
[3] coreos/fedora-coreos-tracker#1495
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue May 26, 2023
@dustymabe
manifests: enable OSTree autopruning for ppc64le
45725fd 
The ppc64le arch has been blocked [1] from being fully released because
of size limitations in /boot not being able to hold 3 copies of
kernel+initramfs because the kernel on ppc64le isn't compressed [2].
Now that OSTree Autopruning [3] has landed let's enable it on ppc64le
to unblock ourselves.

[1] coreos/fedora-coreos-tracker#987 (comment)
[2] coreos/fedora-coreos-tracker#1247 (comment)
[3] coreos/fedora-coreos-tracker#1495
@dustymabe
Copy link
Member

This should handle selectively enabling autopruning coreos/fedora-coreos-config#2435

@dustymabe dustymabe self-assigned this May 26, 2023
@dustymabe dustymabe added the jira for syncing to jira label May 26, 2023
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue May 26, 2023
@dustymabe
manifests: enable OSTree autopruning for ppc64le
f86f944 
The ppc64le arch has been blocked [1] from being fully released because
of size limitations in /boot not being able to hold 3 copies of
kernel+initramfs because the kernel on ppc64le isn't compressed [2].
Now that OSTree Autopruning [3] has landed let's enable it on ppc64le
to unblock ourselves.

[1] coreos/fedora-coreos-tracker#987 (comment)
[2] coreos/fedora-coreos-tracker#1247 (comment)
[3] coreos/fedora-coreos-tracker#1495
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue May 31, 2023
@dustymabe
manifests: enable OSTree autopruning for ppc64le
cea21b3 
The ppc64le arch has been blocked [1] from being fully released because
of size limitations in /boot not being able to hold 3 copies of
kernel+initramfs because the kernel on ppc64le isn't compressed [2].
Now that OSTree Autopruning [3] has landed let's enable it on ppc64le
to unblock ourselves.

[1] coreos/fedora-coreos-tracker#987 (comment)
[2] coreos/fedora-coreos-tracker#1247 (comment)
[3] coreos/fedora-coreos-tracker#1495
dustymabe added a commit to coreos/fedora-coreos-config that referenced this issue May 31, 2023
@dustymabe
manifests: enable OSTree autopruning for ppc64le
3db5dbc 
The ppc64le arch has been blocked [1] from being fully released because
of size limitations in /boot not being able to hold 3 copies of
kernel+initramfs because the kernel on ppc64le isn't compressed [2].
Now that OSTree Autopruning [3] has landed let's enable it on ppc64le
to unblock ourselves.

[1] coreos/fedora-coreos-tracker#987 (comment)
[2] coreos/fedora-coreos-tracker#1247 (comment)
[3] coreos/fedora-coreos-tracker#1495
@dustymabe dustymabe mentioned this issue Jun 6, 2023
Closed
@dustymabe
Copy link
Member

In coreos/fedora-coreos-config#2435 we enabled libostree automatic early pruning for ppc64le and for aarch64 (in F39+), which will get a healthy dose of testing when next switches over to F39 around beta time.

After these test cycles complete hopefully we'll enable the early pruning by default in ostree upstream and we won't carry any enablement config any longer.

I'll close this out since there is no further work for us to do here.

HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
@dustymabe @HuijingHei
manifests: enable OSTree autopruning for ppc64le
e52c04a 
The ppc64le arch has been blocked [1] from being fully released because
of size limitations in /boot not being able to hold 3 copies of
kernel+initramfs because the kernel on ppc64le isn't compressed [2].
Now that OSTree Autopruning [3] has landed let's enable it on ppc64le
to unblock ourselves.

[1] coreos/fedora-coreos-tracker#987 (comment)
[2] coreos/fedora-coreos-tracker#1247 (comment)
[3] coreos/fedora-coreos-tracker#1495
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
@dustymabe @HuijingHei
manifests: enable OSTree autopruning for ppc64le
ec8bc12 
The ppc64le arch has been blocked [1] from being fully released because
of size limitations in /boot not being able to hold 3 copies of
kernel+initramfs because the kernel on ppc64le isn't compressed [2].
Now that OSTree Autopruning [3] has landed let's enable it on ppc64le
to unblock ourselves.

[1] coreos/fedora-coreos-tracker#987 (comment)
[2] coreos/fedora-coreos-tracker#1247 (comment)
[3] coreos/fedora-coreos-tracker#1495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dustymabe dustymabe

Labels
jira for syncing to jira
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cgwalters @dustymabe @jlebon