-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-notes: Initial import for all streams #1124
Conversation
Import a set of JSON files that list issues fixed in a given Fedora CoreOS release. This list will be displayed as part of the release notes at https://getfedora.org/en/coreos See: coreos#194
Looks great! Would we ever hand edit these files? If so maybe we'd want to use yaml instead? |
Good idea. I generally hand edit them. Don't know easy it is to read YAML in Javascript for the website but should not be too hard. |
WDYT about having this in https://github.com/coreos/fedora-coreos-streams instead? That's where new version IDs referenced in these files are blessed and pushed out. We also have some automation there that could in the future roll this up as part of the rollout PR, but we could start doing it manually for now of course. Also, we already have a job that syncs things there to S3 that we can easily tweak. And thanks a lot for working on this! |
fedora-coreos-streams requires two approvals to merge, which already makes it somewhat painful to update the ancillary bits in that repo. For that reason alone I'd be inclined to avoid. There's also some merit to keeping the release notes in the same repo as the bugs they're tracking. |
Syncing to S3 would be nice indeed. I don't have a preference on where to host this but I think we should keep the overhead of updating this file low. We can also move it to another place latter if needed. |
Thinking about this more, making the release notes a part of the release process would make sense (independently from the place where they are stored). |
Closing in favor of coreos/fedora-coreos-streams#477 |
Import a set of JSON files that list issues fixed in a given Fedora CoreOS release.
This list will be displayed as part of the release notes at https://getfedora.org/en/coreos
See: #194