Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-notes: Initial import for all streams #1124

Closed
wants to merge 1 commit into from

Conversation

travier
Copy link
Member

@travier travier commented Mar 16, 2022

Import a set of JSON files that list issues fixed in a given Fedora CoreOS release.

This list will be displayed as part of the release notes at https://getfedora.org/en/coreos

See: #194

Import a set of JSON files that list issues fixed in a given Fedora
CoreOS release.

This list will be displayed as part of the release notes at
https://getfedora.org/en/coreos

See: coreos#194
@dustymabe
Copy link
Member

Looks great! Would we ever hand edit these files? If so maybe we'd want to use yaml instead?

@travier
Copy link
Member Author

travier commented Mar 17, 2022

Looks great! Would we ever hand edit these files? If so maybe we'd want to use yaml instead?

Good idea. I generally hand edit them. Don't know easy it is to read YAML in Javascript for the website but should not be too hard.

@jlebon
Copy link
Member

jlebon commented Mar 17, 2022

WDYT about having this in https://github.com/coreos/fedora-coreos-streams instead? That's where new version IDs referenced in these files are blessed and pushed out. We also have some automation there that could in the future roll this up as part of the rollout PR, but we could start doing it manually for now of course. Also, we already have a job that syncs things there to S3 that we can easily tweak.

And thanks a lot for working on this!

@bgilbert
Copy link
Contributor

bgilbert commented Mar 20, 2022

fedora-coreos-streams requires two approvals to merge, which already makes it somewhat painful to update the ancillary bits in that repo. For that reason alone I'd be inclined to avoid. There's also some merit to keeping the release notes in the same repo as the bugs they're tracking.

@travier
Copy link
Member Author

travier commented Mar 21, 2022

Syncing to S3 would be nice indeed. I don't have a preference on where to host this but I think we should keep the overhead of updating this file low. We can also move it to another place latter if needed.

@travier
Copy link
Member Author

travier commented Mar 22, 2022

Thinking about this more, making the release notes a part of the release process would make sense (independently from the place where they are stored).

@travier
Copy link
Member Author

travier commented Mar 24, 2022

Closing in favor of coreos/fedora-coreos-streams#477

@travier travier closed this Mar 24, 2022
@travier travier deleted the release-notes branch March 24, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants