Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Add Consul support #1004

Closed
wkornewald opened this issue Oct 27, 2014 · 33 comments
Closed

Add Consul support #1004

wkornewald opened this issue Oct 27, 2014 · 33 comments

Comments

@wkornewald
Copy link

Consul comes with health checks, multi-datacenter support and other very nice features. Many people prefer it over etcd, so it would be great if fleet had Consul support.

@bcwaldon
Copy link
Contributor

I'm totally for supporting alternate backends, but unfortunately this involves a nontrivial amount of work. Not only is fleet unprepared for a drop-in etcd replacement, but once it is, there exists the cost to keep supporting said replacement. Given that this is the first time this ticket has been raised, I would like to wait and see if there is a legitimate need for this, or if it is just a "nice to have". Once we've properly vetted the need for this, we can then discuss the path forward. For now, there are no plans to support consul in the immediate future.

@jonboulle
Copy link
Contributor

To add a little more colour: fleet currently relies heavily on the use of TTLs, which do not yet exist in consul.

@JeanMertz
Copy link

Given that this is the first time this ticket has been raised, I would like to wait and see if there is a legitimate need for this, or if it is just a "nice to have".

Just putting down my vote for this. For now, I am running Consul right beside etcd.

@0xgeert
Copy link

0xgeert commented Nov 17, 2014

Same here. Relying on Consul on top of Etcd.

@justinclayton
Copy link

@jonboulle Can you elaborate a bit more? I know consul does support TTL-based checks, but that may not be what you're referring to.

http://www.consul.io/docs/agent/checks.html

@jonboulle
Copy link
Contributor

@justinclayton No, I was talking about per-key TTLs - see here

@justinclayton
Copy link

@jonboulle got it...so perhaps this could be revisited once hashicorp/consul#172 is resolved.

@josh-padnick
Copy link

It looks like hashicorp/consul#172 is now resolved.

@jonboulle
Copy link
Contributor

Waldon and I have limited capacity to work on fleet at the moment so it's very unlikely we can prioritise the considerable amount of work this would involve, but if someone is willing to come up with a patch set we would definitely review it.

@mainframe
Copy link

+1 for fleet with consul backend

@MrJoy
Copy link

MrJoy commented Apr 11, 2015

+1 as well.

@kunthar
Copy link

kunthar commented Apr 13, 2015

+1 and we will check the code soon. 2 months timeframe.

@codebudo
Copy link

+1
Can this be simulated with a sidecar and the Consul http /kv api as a PoC?

@hookenz
Copy link

hookenz commented May 3, 2015

+1. having to use both two KV back-ends seems quite unnecessary. I prefer consul over etcd.

@pmoust
Copy link

pmoust commented May 8, 2015

big 👍 on this.

@atomi
Copy link

atomi commented Jun 11, 2015

Supporting Consul is a good way to get folks turned on to Core OS. 👍

@gmr
Copy link

gmr commented Jul 15, 2015

+1 here -- I'm using Consul next to fleet.

@xied75
Copy link

xied75 commented Jul 29, 2015

👍

So the consul binary would be built into CoreOS image and we can start it in cloud-config.yaml? How do we specify how many server and clients we want?

@ilijaljubicic
Copy link

+1

4 similar comments
@nicolaballotta
Copy link

+1

@scrothers
Copy link

+1

@alwinmark
Copy link

+1

@ThatsNinja
Copy link

+1

@MrJoy
Copy link

MrJoy commented Jan 5, 2016

Any plans to revisit this given that there's fairly clearly interest, and Consul now has per-key TTLs?

@scrothers
Copy link

@MrJoy I think part of the problem is that the ticket is closed. If anyone knows anybody from the Fleet team, perhaps they get it re-opened, even if only to re-close it again.

@crawford
Copy link
Contributor

crawford commented Jan 5, 2016

We are open to patches but it doesn't make a whole lot of sense for us to invest in features like this right now. We've narrowed our focus to (mainly) bug fixes at this point. Once we have some free cycles, we can reinvestigate this.

@OferE
Copy link

OferE commented Mar 10, 2016

+1 - why do you enforce the use of etcd?
I already have consul up and running and i don't need the etcd cluster.

@jonboulle
Copy link
Contributor

As crawford mentioned, we just have no plans in our own roadmap to add support, but we'd be very receptive to clean patchsets to add it.

@kunthar
Copy link

kunthar commented Mar 10, 2016

it is your very own case and your decision not to use etcd.
i have no direct relation with coreos and i want to use in combination with
my very own case. hope i am free to do this?
On Mar 10, 2016 3:28 PM, "OferE" notifications@github.com wrote:

+1 - why do you enforce the use of etcd?
I? already have consul up and running and i don't need the etcd cluster.


Reply to this email directly or view it on GitHub
#1004 (comment).

@celevra
Copy link

celevra commented May 4, 2016

+1

3 similar comments
@siddharthlatest
Copy link

+1

@ghost
Copy link

ghost commented Sep 6, 2016

+1

@jhmartin
Copy link

+1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests