This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 302
fleetctl (0.11.5) destroy is not backward compatible #1383
Comments
this was introduced by 9530eed |
Note that other fleetctl commands for units that do not exist do not generate the error message or exit code: core@core-01 ~ $ fleetctl --version
fleetctl version 0.11.5
core@core-01 ~ $ fleetctl stop fubar; echo $?
0
core@core-01 ~ $ fleetctl unload fubar; echo $?
0 |
tixxdz
pushed a commit
to endocode/fleet
that referenced
this issue
Feb 1, 2016
fleetctl used to ignore requests to destory units which do not actually exist. This behaviour was changed by commit 9530eed, restore the older behaviour by calling findUnits() to get the right list of units. This fixes: coreos#1383
tixxdz
pushed a commit
to endocode/fleet
that referenced
this issue
Feb 17, 2016
Do not error out directly if Destroy command fails, check first if the unit does really exist if no then ignore the destroy error and continue. Follow-up fix for: coreos#1383
tixxdz
pushed a commit
to endocode/fleet
that referenced
this issue
Feb 17, 2016
Do not error out directly if Destroy command fails, check first if the unit does really exist if no then ignore the destroy error and continue. Follow-up fix for: coreos#1383
kayrus
pushed a commit
to endocode/fleet
that referenced
this issue
Mar 31, 2016
fleetctl used to ignore requests to destory units which do not actually exist. This behaviour was changed by commit 9530eed, restore the older behaviour by calling findUnits() to get the right list of units. This fixes: coreos#1383
kayrus
pushed a commit
to endocode/fleet
that referenced
this issue
Mar 31, 2016
fleetctl used to ignore requests to destory units which do not actually exist. This behaviour was changed by commit 9530eed, restore the older behaviour by calling findUnits() to get the right list of units. This fixes: coreos#1383
hectorj2f
pushed a commit
to giantswarm/fleet
that referenced
this issue
Apr 6, 2016
fleetctl used to ignore requests to destory units which do not actually exist. This behaviour was changed by commit 9530eed, restore the older behaviour by calling findUnits() to get the right list of units. This fixes: coreos#1383
Would it be possible to backport the fix in #1417 into |
@megahall 👍 |
Downstream report filed as coreos/bugs#1448 . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Older versions of fleetctl seems to ignore the request to destroy units which do not actually exist. This was a handy command to use for startup / provisioning / startup scrips to stop and destroy a unit that may or may not actually be loaded.
However, fleetctl 0.11.5 causes destroy show an unhelpful error message and exit with code 1 if the unit is not loaded
This has now hit the beta channel and broke some of our development and test deployment scripts.
Is the new behavior a regression, bug, or a feature?
The text was updated successfully, but these errors were encountered: