This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
fleetctl: support options --no-block, --block-attempts for destroy command #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongsupark
force-pushed
the
dongsu/fleetctl-destroy-block-flags
branch
from
3957aec to
06302c8
Compare
|
Huh. Great catch! LGTM |
dongsupark
force-pushed
the
dongsu/fleetctl-destroy-block-flags
branch
from
06302c8 to
c0bcf1f
Compare
|
Fixed minor typos: |
dongsupark
force-pushed
the
dongsu/fleetctl-destroy-block-flags
branch
from
c0bcf1f to
c38bfac
Compare
…mmand Apparently fleetctl destroy command has never supported both options --no-block and --block-attempts, although runDestroyUnit() tries to use the flags. Fix it by defining the options for cmdDestroy.
dongsupark
pushed a commit
that referenced
this pull request
Aug 23, 2016
…flags fleetctl: support options --no-block, --block-attempts for destroy command
dongsupark
pushed a commit
that referenced
this pull request
Aug 23, 2016
…flags fleetctl: support options --no-block, --block-attempts for destroy command
dongsupark
pushed a commit
that referenced
this pull request
Aug 23, 2016
…flags fleetctl: support options --no-block, --block-attempts for destroy command
dongsupark
pushed a commit
that referenced
this pull request
Aug 23, 2016
…flags fleetctl: support options --no-block, --block-attempts for destroy command
dongsupark
pushed a commit
that referenced
this pull request
Aug 23, 2016
…flags fleetctl: support options --no-block, --block-attempts for destroy command
dongsupark
pushed a commit
that referenced
this pull request
Aug 23, 2016
…flags fleetctl: support options --no-block, --block-attempts for destroy command
dongsupark
pushed a commit
that referenced
this pull request
Aug 23, 2016
…flags fleetctl: support options --no-block, --block-attempts for destroy command
dongsupark
pushed a commit
that referenced
this pull request
Aug 23, 2016
…flags fleetctl: support options --no-block, --block-attempts for destroy command
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently fleetctl destroy command has never supported both options
--no-blockand--block-attempts, althoughrunDestroyUnit()tries to use the flags. Fix it by defining the options forcmdDestroy.Note that it's not a regression caused by conversion into cobra. It has been just like that since the beginning. I just happened to find it out yesterday when I was working on #1664 .